Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js

Issue 2188413004: DevTools: Remove Advanced heap snapshot properties setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyrightdd 8 * * Redistributions of source code must retain the above copyrightdd
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 */ 290 */
291 close: function(callback) 291 close: function(callback)
292 { 292 {
293 /** 293 /**
294 * @this {WebInspector.HeapSnapshotLoaderProxy} 294 * @this {WebInspector.HeapSnapshotLoaderProxy}
295 */ 295 */
296 function buildSnapshot() 296 function buildSnapshot()
297 { 297 {
298 if (callback) 298 if (callback)
299 callback(); 299 callback();
300 var showHiddenData = WebInspector.moduleSetting("showAdvancedHeapSna pshotProperties").get(); 300 this.callFactoryMethod(updateStaticData.bind(this), "buildSnapshot", WebInspector.HeapSnapshotProxy);
301 this.callFactoryMethod(updateStaticData.bind(this), "buildSnapshot", WebInspector.HeapSnapshotProxy, showHiddenData);
302 } 301 }
303 302
304 /** 303 /**
305 * @param {!WebInspector.HeapSnapshotProxy} snapshotProxy 304 * @param {!WebInspector.HeapSnapshotProxy} snapshotProxy
306 * @this {WebInspector.HeapSnapshotLoaderProxy} 305 * @this {WebInspector.HeapSnapshotLoaderProxy}
307 */ 306 */
308 function updateStaticData(snapshotProxy) 307 function updateStaticData(snapshotProxy)
309 { 308 {
310 this.dispose(); 309 this.dispose();
311 snapshotProxy.setProfileUid(this._profileUid); 310 snapshotProxy.setProfileUid(this._profileUid);
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 * @param {!WebInspector.HeapSnapshotCommon.ComparatorConfig} comparator 569 * @param {!WebInspector.HeapSnapshotCommon.ComparatorConfig} comparator
571 * @return {!Promise<?>} 570 * @return {!Promise<?>}
572 */ 571 */
573 sortAndRewind: function(comparator) 572 sortAndRewind: function(comparator)
574 { 573 {
575 return this._callMethodPromise("sortAndRewind", comparator); 574 return this._callMethodPromise("sortAndRewind", comparator);
576 }, 575 },
577 576
578 __proto__: WebInspector.HeapSnapshotProxyObject.prototype 577 __proto__: WebInspector.HeapSnapshotProxyObject.prototype
579 } 578 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698