Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2188413004: DevTools: Remove Advanced heap snapshot properties setting. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove Advanced heap snapshot properties setting. Make it always show all the object properties. BUG=632917 Committed: https://crrev.com/b13b5d875d636d36617943e2dfb2dcf2831cc28a Cr-Commit-Position: refs/heads/master@{#408859}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 10 (3 generated)
alph
4 years, 4 months ago (2016-07-30 00:02:21 UTC) #2
caseq
https://codereview.chromium.org/2188413004/diff/1/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js File third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js (right): https://codereview.chromium.org/2188413004/diff/1/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js#newcode238 third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js:238: userObjectsMapAndFlag: function() let's drop it altogether and inline.
4 years, 4 months ago (2016-07-30 00:26:26 UTC) #3
caseq
lgtm
4 years, 4 months ago (2016-07-30 00:29:24 UTC) #4
alph
https://codereview.chromium.org/2188413004/diff/1/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js File third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js (right): https://codereview.chromium.org/2188413004/diff/1/third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js#newcode238 third_party/WebKit/Source/devtools/front_end/heap_snapshot_worker/JSHeapSnapshot.js:238: userObjectsMapAndFlag: function() On 2016/07/30 00:26:26, caseq wrote: > let's ...
4 years, 4 months ago (2016-07-30 00:31:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188413004/1
4 years, 4 months ago (2016-07-30 01:42:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-30 04:05:15 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 04:07:27 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b13b5d875d636d36617943e2dfb2dcf2831cc28a
Cr-Commit-Position: refs/heads/master@{#408859}

Powered by Google App Engine
This is Rietveld 408576698