Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2188413002: Revert of cc : Use screen space transform for computing translation (Closed)

Created:
4 years, 4 months ago by tapted
Modified:
4 years, 4 months ago
Reviewers:
jaydasika, ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org, sunxd
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc : Use screen space transform for computing translation (patchset #3 id:40001 of https://codereview.chromium.org/2187403002/ ) Reason for revert: Causes ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate to fail on linux debug links: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/56008 https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32)/builds/31557 errors like ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate (run #1): [ RUN ] ExtensionCrxInstallerTest.InstallDelayedUntilNextUpdate [1:1:0728/152609:FATAL:property_tree.cc(181)] Check failed: transform->IsApproximatelyIdentityOrTranslation(SkDoubleToMScalar(1e-4)). .. #2 0x7f99d9f73a0d cc::TransformTree::ComputeTranslation() #3 0x7f99d9f74189 cc::TransformTree::UpdateLocalTransform() #4 0x7f99d9f73ece cc::TransformTree::UpdateTransforms() #5 0x7f99d9fa0ce0 cc::(anonymous namespace)::AddTransformNodeIfNeeded<>() #6 0x7f99d9f9e98d cc::(anonymous namespace)::BuildPropertyTreesInternal<>() Original issue's description: > cc : Use screen space transform computing translation > > Since flattenning won't effect the result, > TransformTree::ComputeTranslation can use screen space transform instead > of calling ComputeTransforms. > > BUG=622372 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/b7a8f7678a999ba33e509e918e8e339956e3d150 > Cr-Commit-Position: refs/heads/master@{#408462} TBR=weiliangc@chromium.org,ajuma@chromium.org,jaydasika@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622372 Committed: https://crrev.com/6ccab66beb7c4899126c92d6e7fe5cf8204c241a Cr-Commit-Position: refs/heads/master@{#408533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M cc/trees/property_tree.h View 1 chunk +1 line, -4 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +2 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tapted
Created Revert of cc : Use screen space transform for computing translation
4 years, 4 months ago (2016-07-29 00:42:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188413002/1
4 years, 4 months ago (2016-07-29 00:43:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 00:43:45 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 00:45:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ccab66beb7c4899126c92d6e7fe5cf8204c241a
Cr-Commit-Position: refs/heads/master@{#408533}

Powered by Google App Engine
This is Rietveld 408576698