Revert "fix #26141, add support for type arguments to constants"

Revert "fix #26141, add support for type arguments to constants"

This reverts commit 5d155000af4285db51976d0722989081e27a415f.

Seems to have lost an error regarding type literals used in non-strong mode. Probably an easy fix, but reverting for simplicity.

Committed: https://github.com/dart-lang/sdk/commit/bd6669ee114bd9cc2eb0d8efd00e15eb329455b4

[Jennifer Messerly, 2016-07-28 23:52:09]

Description was changed from

==========
Revert "fix #26141, add support for type arguments to constants"

This reverts commit 5d155000af4285db51976d0722989081e27a415f.

Seems to have lost an error regarding type literals used in non-strong mode.
Probably an easy fix, but reverting for simplicity.
==========

to

==========
Revert "fix #26141, add support for type arguments to constants"

This reverts commit 5d155000af4285db51976d0722989081e27a415f.

Seems to have lost an error regarding type literals used in non-strong mode.
Probably an easy fix, but reverting for simplicity.

Committed:
https://github.com/dart-lang/sdk/commit/bd6669ee114bd9cc2eb0d8efd00e15eb329455b4
==========

[Jennifer Messerly, 2016-07-28 23:52:11]

Committed patchset #1 (id:1) manually as
bd6669ee114bd9cc2eb0d8efd00e15eb329455b4 (presubmit successful).

[Jennifer Messerly, 2016-07-28 23:54:20]

jmesserly@google.com changed reviewers:
+ paulberry@google.com

[Jennifer Messerly, 2016-07-28 23:54:21]

FYI to you Paul, I should have a follow up shortly. All checks in ErrorVerifier
were guarded with !strongMode, so I'm guessing that perhaps it's because we
implement visitTypeName now.

[Jennifer Messerly, 2016-07-28 23:55:38]

On 2016/07/28 23:54:21, John Messerly wrote:
> FYI to you Paul, I should have a follow up shortly. All checks in
ErrorVerifier
> were guarded with !strongMode, so I'm guessing that perhaps it's because we
> implement visitTypeName now.

Oh, and this was caught by the bots. I had run Analyzer's package tests but not
the full suite of lang tests. Usually strong mode changes can't affect them, but
this one appears to have done so unintentionally.