Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2188383002: Try to fix flakiness of fast/repaint/window-resize-background-image*.html (Closed)

Created:
4 years, 4 months ago by Xianzhu
Modified:
4 years, 4 months ago
Reviewers:
wkorman
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to fix flakiness of fast/repaint/window-resize-background-image*.html The flakiness may be because sometimes the test was started before the image is loaded. Now start the test in onload. Remove wrong baselines that were created based on wrong results when the test failed on the bots. BUG=622898 Committed: https://crrev.com/4642f6d990020c2d15902b0de97b0acc70defc51 Cr-Commit-Position: refs/heads/master@{#408795}

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1961 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js View 1 chunk +4 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 1 chunk +0 lines, -77 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-background-image-fixed-centered-expected.txt View 1 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-background-image-generated-expected.txt View 1 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 1 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux-precise/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 1 chunk +0 lines, -141 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 1 chunk +0 lines, -150 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 1 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/window-resize-background-image-fixed-centered-expected.txt View 1 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 1 chunk +0 lines, -141 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 1 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 1 chunk +0 lines, -159 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 1 1 chunk +0 lines, -154 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-fixed-centered-composited-expected.txt View 1 chunk +0 lines, -141 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-fixed-centered-expected.txt View 1 1 chunk +0 lines, -154 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/fast/repaint/window-resize-background-image-non-fixed-expected.txt View 1 1 chunk +0 lines, -154 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
Xianzhu
4 years, 4 months ago (2016-07-29 20:57:57 UTC) #10
wkorman
lgtm
4 years, 4 months ago (2016-07-29 22:21:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188383002/20001
4 years, 4 months ago (2016-07-29 22:58:38 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 23:03:48 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 23:08:00 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4642f6d990020c2d15902b0de97b0acc70defc51
Cr-Commit-Position: refs/heads/master@{#408795}

Powered by Google App Engine
This is Rietveld 408576698