Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2188353002: Reland of Update the nacl_bootstrap GN code to work in ChromeOS chroot builds. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Reland of Update the nacl_bootstrap GN code to work in ChromeOS chroot builds. (patchset #1 id:1 of https://codereview.chromium.org/2188303002/ ) Reason for revert: re-reverting (i.e., relanding), since we're not sure this'll actually fix things. Original issue's description: > Revert of Update the nacl_bootstrap GN code to work in ChromeOS chroot builds. (patchset #2 id:20001 of https://codereview.chromium.org/2085683004/ ) > > Reason for revert: > It looks like this breaks CrOS ARM builds; see crbug.com/629593 . > > Original issue's description: > > Update the nacl_bootstrap GN code to work in ChromeOS chroot builds. > > > > In ChromeOS chroot builds, they use their own compiler toolchain > > and set a bunch of target flags, and the prior version of the > > nacl_bootstrap_* toolchains weren't picking them up properly. > > > > This CL switches to use the new //build/toolchain/cros:nacl_bootstrap > > toolchain that mimics the //build/toolchain/cros:target toolchain and uses > > all of the same settings except that it forces off use_debug_fission > > and use_gold. > > > > R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org > > BUG=621686 > > > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/0949e1bef9d6b25ee44eb69a54e0cc6f8a677375 > > TBR=llozano@chromium.org,mcgrathr@chromium.org,bradnelson@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=621686 > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/a07450d163bfb18a469db4e630a632f2f206c9cf TBR=llozano@chromium.org,mcgrathr@chromium.org,bradnelson@chromium.org,llozano@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621686 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/5e296cb4749c3b48653eb6e5888947ad4aa86d3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/trusted/service_runtime/linux/BUILD.gn View 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Dirk Pranke
Created Reland of Update the nacl_bootstrap GN code to work in ChromeOS chroot builds.
4 years, 4 months ago (2016-07-28 21:35:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188353002/1
4 years, 4 months ago (2016-07-28 21:35:51 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-07-28 21:35:53 UTC) #5
Roland McGrath
lgtm
4 years, 4 months ago (2016-07-28 21:37:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188353002/1
4 years, 4 months ago (2016-07-28 21:39:41 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:39:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/5e296cb47...

Powered by Google App Engine
This is Rietveld 408576698