DescriptionReland of Update the nacl_bootstrap GN code to work in ChromeOS chroot builds. (patchset #1 id:1 of https://codereview.chromium.org/2188303002/ )
Reason for revert:
re-reverting (i.e., relanding), since we're not sure this'll actually fix things.
Original issue's description:
> Revert of Update the nacl_bootstrap GN code to work in ChromeOS chroot builds. (patchset #2 id:20001 of https://codereview.chromium.org/2085683004/ )
>
> Reason for revert:
> It looks like this breaks CrOS ARM builds; see crbug.com/629593 .
>
> Original issue's description:
> > Update the nacl_bootstrap GN code to work in ChromeOS chroot builds.
> >
> > In ChromeOS chroot builds, they use their own compiler toolchain
> > and set a bunch of target flags, and the prior version of the
> > nacl_bootstrap_* toolchains weren't picking them up properly.
> >
> > This CL switches to use the new //build/toolchain/cros:nacl_bootstrap
> > toolchain that mimics the //build/toolchain/cros:target toolchain and uses
> > all of the same settings except that it forces off use_debug_fission
> > and use_gold.
> >
> > R=mcgrathr@chromium.org, llozano@chromium.org, bradnelson@chromium.org
> > BUG=621686
> >
> > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/0949e1bef9d6b25ee44eb69a54e0cc6f8a677375
>
> TBR=llozano@chromium.org,mcgrathr@chromium.org,bradnelson@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=621686
>
> Committed: https://chromium.googlesource.com/native_client/src/native_client/+/a07450d163bfb18a469db4e630a632f2f206c9cf
TBR=llozano@chromium.org,mcgrathr@chromium.org,bradnelson@chromium.org,llozano@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=621686
Committed: https://chromium.googlesource.com/native_client/src/native_client/+/5e296cb4749c3b48653eb6e5888947ad4aa86d3a
Patch Set 1 #
Messages
Total messages: 10 (4 generated)
|