Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 218833005: Pass the IDWriteFactory instead of relying on a global creator. (Closed)

Created:
6 years, 8 months ago by bungeman-skia
Modified:
6 years, 8 months ago
Reviewers:
scottmg, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Pass the IDWriteFactory instead of relying on a global creator. There are different variations or implementations of IDWriteFactory with different behaviors. Allow the user to specify the factory to use. R=scottmg@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=14000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -106 lines) Patch
M gm/fontmgr.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M include/ports/SkTypeface_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_win_dw.cpp View 18 chunks +97 lines, -101 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
This is an alternative to https://codereview.chromium.org/217733002/ . This is what we already should be doing, ...
6 years, 8 months ago (2014-03-31 17:57:21 UTC) #1
scottmg
Thanks! lgtm for what that's worth. (Perhaps remove sk_get_dwrite_factory from utils\win\SkDWrite so the wrong one ...
6 years, 8 months ago (2014-03-31 18:35:32 UTC) #2
bungeman-skia
6 years, 8 months ago (2014-03-31 19:18:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14000.

Powered by Google App Engine
This is Rietveld 408576698