Mojo: Move public/tests/test_{support,utils}.* to public/{c,cpp}/test_support.

Mojo: Move public/tests/test_{support,utils}.* to public/{c,cpp}/test_support.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260553

[darin (slow to review), 2014-03-31 04:13:36]

Did you mean to add a public/c/test_support/lib/test_support.c{c}?

[darin (slow to review), 2014-03-31 04:15:24]

On 2014/03/31 04:13:36, darin wrote:
> Did you mean to add a public/c/test_support/lib/test_support.c{c}?

Oh, nevermind... I was looking for the implementation of
MojoTestSupportLogPerfResult. Found it.

[darin (slow to review), 2014-03-31 04:17:03]

LGTM... not sure how I really feel about having .cc files under the public/c/
directory. Initial reaction is that it feels wrong. I realize it is a test of
the C interface. Hmm...

[viettrungluu, 2014-03-31 04:28:00]

On 2014/03/31 04:17:03, darin wrote:
> LGTM... not sure how I really feel about having .cc files under the public/c/
> directory. Initial reaction is that it feels wrong. I realize it is a test of
> the C interface. Hmm...

We already do that for c/system. Otherwise, we'd have to find a reasonable way
to use gtest in .c files, or put the tests somewhere else. (The former would be
ideal, of course, but I don't know of a reasonable way to do it.)

[darin (slow to review), 2014-03-31 05:01:06]

Makes sense. OK.
On Mar 30, 2014 9:28 PM, <viettrungluu@chromium.org> wrote:

> On 2014/03/31 04:17:03, darin wrote:
>
>> LGTM... not sure how I really feel about having .cc files under the
>> public/c/
>> directory. Initial reaction is that it feels wrong. I realize it is a
>> test of
>> the C interface. Hmm...
>>
>
> We already do that for c/system. Otherwise, we'd have to find a reasonable
> way
> to use gtest in .c files, or put the tests somewhere else. (The former
> would be
> ideal, of course, but I don't know of a reasonable way to do it.)
>
> https://codereview.chromium.org/218833003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[viettrungluu, 2014-03-31 16:22:51]

Committed patchset #2 manually as r260553 (presubmit successful).