Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2188323002: [chromedriver] Update chrome_paths to use GN build directory. (Closed)

Created:
4 years, 4 months ago by samuong
Modified:
4 years, 4 months ago
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Update chrome_paths to use GN build directory. BUG=632389 TBR=stgao@chromium.org Committed: https://crrev.com/31c70814160f9d3b9a1631797de672d4bee68f70 Cr-Commit-Position: refs/heads/master@{#408463}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M chrome/test/chromedriver/chrome_paths.py View 1 chunk +6 lines, -12 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
samuong
Now that the ChromeDriver bots are usign GN, we need to update the build dir ...
4 years, 4 months ago (2016-07-28 19:04:39 UTC) #2
samuong
Going with TBR since Shuotao's OOO and the bot is broken.
4 years, 4 months ago (2016-07-28 19:13:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188323002/1
4 years, 4 months ago (2016-07-28 19:14:32 UTC) #6
jbudorick
lgtm https://codereview.chromium.org/2188323002/diff/1/chrome/test/chromedriver/chrome_paths.py File chrome/test/chromedriver/chrome_paths.py (right): https://codereview.chromium.org/2188323002/diff/1/chrome/test/chromedriver/chrome_paths.py#newcode26 chrome/test/chromedriver/chrome_paths.py:26: build_dir = os.path.join(GetSrc(), 'out', 'Default') I take it ...
4 years, 4 months ago (2016-07-28 19:16:11 UTC) #7
samuong
Yes, they're all going to out/Default.
4 years, 4 months ago (2016-07-28 19:18:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 20:26:16 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 20:28:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31c70814160f9d3b9a1631797de672d4bee68f70
Cr-Commit-Position: refs/heads/master@{#408463}

Powered by Google App Engine
This is Rietveld 408576698