Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2188303003: SkPDF: drawText makes use of SkPaint.measureText() for alignment. (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: drawText makes use of SkPaint.measureText() for alignment. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188303003 Committed: https://skia.googlesource.com/skia/+/00450f1ae570a2efdbb93c88140b49c7ee84473b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -33 lines) Patch
M src/pdf/SkPDFDevice.cpp View 4 chunks +10 lines, -33 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hal.canary
PTAL
4 years, 4 months ago (2016-07-28 18:46:57 UTC) #3
bungeman-skia
why not, lgtm
4 years, 4 months ago (2016-07-28 21:23:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188303003/1
4 years, 4 months ago (2016-07-28 21:32:14 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:33:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/00450f1ae570a2efdbb93c88140b49c7ee84473b

Powered by Google App Engine
This is Rietveld 408576698