base/process/kill_posix.cc - Issue 2188293002: Correctly detect renderer crash because of CHECK failures on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process/kill_posix.cc

Issue 2188293002: Correctly detect renderer crash because of CHECK failures on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/process/kill_posix.cc

diff --git a/base/process/kill_posix.cc b/base/process/kill_posix.cc

index 85470e05f971b1f21f6bbb3af023b1dce77bcf1b..76eb39243f22c84be8411a2f53cfa7e85d75efff 100644

--- a/base/process/kill_posix.cc

+++ b/base/process/kill_posix.cc

@@ -52,6 +52,7 @@ TerminationStatus GetTerminationStatusImpl(ProcessHandle handle,

case SIGFPE:

case SIGILL:

case SIGSEGV:

+ case SIGTRAP:

Mark Mentovai 2016/07/28 18:23:34 We should add SIGSYS too.

Xianzhu 2016/07/28 19:23:39 Done.

return TERMINATION_STATUS_PROCESS_CRASHED;

case SIGKILL:

#if defined(OS_CHROMEOS)

« no previous file with comments | « no previous file | no next file » | no next file with comments »