Correctly detect renderer crash because of CHECK failures on Mac

Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BTW also for SIGSYS.

BUG=619153
Committed: https://crrev.com/bcb53cbb96304db38bb0a2774c26657f518e851e
Cr-Commit-Position: refs/heads/master@{#408469}

[Xianzhu, 2016-07-28 18:17:03]

wangxianzhu@chromium.org changed reviewers:
+ mark@chromium.org, thestig@chromium.org

[Xianzhu, 2016-07-28 18:17:51]

Description was changed from

==========
Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crashes on
other platforms.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BUG=619153
==========

to

==========
Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BUG=619153
==========

[Mark Mentovai, 2016-07-28 18:23:34]

LGTM

https://codereview.chromium.org/2188293002/diff/1/base/process/kill_posix.cc
File base/process/kill_posix.cc (right):

https://codereview.chromium.org/2188293002/diff/1/base/process/kill_posix.cc#...
base/process/kill_posix.cc:55: case SIGTRAP:
We should add SIGSYS too.

[Xianzhu, 2016-07-28 18:47:21]

Description was changed from

==========
Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BUG=619153
==========

to

==========
Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BTW also for SIGSYS.

BUG=619153
==========

[Xianzhu, 2016-07-28 18:47:48]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-07-28 18:47:48]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2188293002/#ps20001
(title: "SIGSYS")

[commit-bot: I haz the power, 2016-07-28 18:48:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-07-28 19:23:40]

https://codereview.chromium.org/2188293002/diff/1/base/process/kill_posix.cc
File base/process/kill_posix.cc (right):

https://codereview.chromium.org/2188293002/diff/1/base/process/kill_posix.cc#...
base/process/kill_posix.cc:55: case SIGTRAP:
On 2016/07/28 18:23:34, Mark Mentovai wrote:
> We should add SIGSYS too.

Done.

[commit-bot: I haz the power, 2016-07-28 20:41:13]

Description was changed from

==========
Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BTW also for SIGSYS.

BUG=619153
==========

to

==========
Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BTW also for SIGSYS.

BUG=619153
==========

[commit-bot: I haz the power, 2016-07-28 20:41:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 20:44:07]

Description was changed from

==========
Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BTW also for SIGSYS.

BUG=619153
==========

to

==========
Correctly detect renderer crash because of CHECK failures on Mac

Previously CHECK failures on Mac (SIGTRAP) were treated as
TERMINATION_STATUS_NORMAL_TERMINATION and content_shell will timeout
instead of printing #CRASH. We had to put TIMEOUT expectation in
LayoutTests/TestExpectations for Mac for layout tests that crash
because of CHECK failures.

Return TERMINATION_STATUS_PROCESS_CRASHED for SIGTRAP.

BTW also for SIGSYS.

BUG=619153

Committed: https://crrev.com/bcb53cbb96304db38bb0a2774c26657f518e851e
Cr-Commit-Position: refs/heads/master@{#408469}
==========

[commit-bot: I haz the power, 2016-07-28 20:44:08]

Patchset 2 (id:??) landed as
https://crrev.com/bcb53cbb96304db38bb0a2774c26657f518e851e
Cr-Commit-Position: refs/heads/master@{#408469}