Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2188263002: GN: add abbreviated versions of the command line as descriptions. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: add abbreviated versions of the command line as descriptions. This should help make the bot logs a little easier to read. (On the console this wasn't much of a big deal, as Ninja auto-abbreviates when printing to an interactive console.) As usual, Ninja will print the full command when a task fails. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188263002 Committed: https://skia.googlesource.com/skia/+/f05c2c22a76acd99b10c2a0d9b72b35c9c8d2458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gn/BUILD.gn View 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 4 months ago (2016-07-28 17:19:37 UTC) #3
jcgregorio
lgtm
4 years, 4 months ago (2016-07-28 17:28:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188263002/1
4 years, 4 months ago (2016-07-28 17:48:53 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 18:42:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f05c2c22a76acd99b10c2a0d9b72b35c9c8d2458

Powered by Google App Engine
This is Rietveld 408576698