predictors: Don't cancel the request when IO is pending.

chrome/browser/predictors/resource_prefetcher.cc

Index: chrome/browser/predictors/resource_prefetcher.cc
diff --git a/chrome/browser/predictors/resource_prefetcher.cc b/chrome/browser/predictors/resource_prefetcher.cc
index b9b01543dcbd1bb27819dcd312ae5f22cd2cb47b..b81ff69255c7e3aad503dcaa30acb3e8c077179f 100644
--- a/chrome/browser/predictors/resource_prefetcher.cc
+++ b/chrome/browser/predictors/resource_prefetcher.cc
@@ -177,7 +177,7 @@ void ResourcePrefetcher::ReadFullResponse(net::URLRequest* request) {
 
     if (status) {
       status = ShouldContinueReadingRequest(request, bytes_read);
-    } else if (request->status().error()) {
+    } else if (!request->status().is_success()) {

[pasko, 2016/07/29 09:35:29]

I could be missing something .. but will this not turn into a busy loop at
IO_PENDING?

The async read that we started on line 176 will only change the
request->status() before the OnReadCompleted() is called, but we are occupying
the thread here for it to happen.

Seems like we should break out of the loop and continue in OnReadCompleted().

[pasko, 2016/07/29 09:40:42]

oh, my reading was wrong, the status is actually false and we will break out of
the loop.

       FinishRequest(request, Request::PREFETCH_STATUS_FAILED);
       return;
     }
@@ -222,7 +222,7 @@ void ResourcePrefetcher::OnSSLCertificateError(net::URLRequest* request,
 }
 
 void ResourcePrefetcher::OnResponseStarted(net::URLRequest* request) {
-  if (request->status().error()) {
+  if (!request->status().is_success()) {
     FinishRequest(request, Request::PREFETCH_STATUS_FAILED);
     return;
   }
@@ -233,7 +233,7 @@ void ResourcePrefetcher::OnResponseStarted(net::URLRequest* request) {
 
 void ResourcePrefetcher::OnReadCompleted(net::URLRequest* request,
                                          int bytes_read) {
-  if (request->status().error()) {
+  if (!request->status().is_success()) {
     FinishRequest(request, Request::PREFETCH_STATUS_FAILED);
     return;
   }