Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2188203002: [DevTools] implement isSpaceOrNewline for the STL string wrapper. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] implement isSpaceOrNewline for the STL string wrapper. We now use std::isspace, which is not equivalent to the WTF implementation. But it is consistent with the STL version of String16::stripWhiteSpace. With this, the inspector protocol parser test succeeds in the V8 standalone build that uses the STL string wrapper. R=dgozman@chromium.org BUG=580337 Committed: https://crrev.com/fc6d7b372defe05402d8d035608a3af5f2e2f9f2 Cr-Commit-Position: refs/heads/master@{#408591}

Patch Set 1 #

Patch Set 2 : add include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/platform/inspector_protocol/String16STL.h View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
4 years, 4 months ago (2016-07-28 13:23:03 UTC) #1
dgozman
lgtm
4 years, 4 months ago (2016-07-28 16:58:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188203002/1
4 years, 4 months ago (2016-07-28 17:48:47 UTC) #4
pfeldman
it is unlikely to build for all node configs unless you include ctype.
4 years, 4 months ago (2016-07-28 18:00:42 UTC) #6
Yang
On 2016/07/28 18:00:42, pfeldman wrote: > it is unlikely to build for all node configs ...
4 years, 4 months ago (2016-07-29 05:22:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188203002/20001
4 years, 4 months ago (2016-07-29 05:22:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 06:52:31 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 06:56:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc6d7b372defe05402d8d035608a3af5f2e2f9f2
Cr-Commit-Position: refs/heads/master@{#408591}

Powered by Google App Engine
This is Rietveld 408576698