Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2188193002: [api] Remove HistogramTimerScope from high-frequency API-Functions (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Remove HistogramTimerScope from high-frequency API-Functions The timing scopes don't come for free and in the case of wrapper creation only add overhead. This CL removes the histogram timer for CallAs(Function|Constructor) and Function::(NewInstance|Call). BUG=chromium:630217 Committed: https://crrev.com/ba6e348ffe703b858730a7d10b06c2f92f8a205c Cr-Commit-Position: refs/heads/master@{#38138}

Patch Set 1 #

Patch Set 2 : make TimerEventScope inlineable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M src/api.cc View 1 4 chunks +0 lines, -4 lines 0 comments Download
M src/log.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/log.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/log-inl.h View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-07-28 13:19:21 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-28 13:23:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188193002/20001
4 years, 4 months ago (2016-07-28 13:30:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 14:02:53 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 14:04:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba6e348ffe703b858730a7d10b06c2f92f8a205c
Cr-Commit-Position: refs/heads/master@{#38138}

Powered by Google App Engine
This is Rietveld 408576698