MD Settings: Internet: Add 'forget' button, more fixes.

MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Fixes a minor idl error causing console errors
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=asargant@ for trivial idl change

Committed: https://crrev.com/fec4adcb237c41d8c6c1c787ba87014263d3c29f
Cr-Commit-Position: refs/heads/master@{#409410}

[stevenjb, 2016-07-28 19:17:31]

Description was changed from

==========
MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
==========

to

==========
MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2016-07-28 19:20:13]

Description was changed from

==========
MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Fixes a minor idl error causing console errors
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=asargant@ for trivial idl change
==========

[stevenjb, 2016-07-28 19:22:20]

stevenjb@chromium.org changed reviewers:
+ dschuyler@chromium.org

[stevenjb, 2016-07-28 19:22:21]

Getting close now...

[dschuyler, 2016-07-28 22:03:56]

Please also add the files to the 
compiled_resources.gyp so they get compiled
(such as internet_detail_page.js).

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.html
(right):

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.html:83:
Forget
I think we should $i18n{} the network settings
soon; and I don't want to muddle this CL with 
changing all of them, but can this entry be 
$i18n?

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:134:
}.bind(this));
setTimeout and async come up as problems often
enough that I'd like to ask if there is another
way to handle this in a more bulletproof way?
Is there an event to watch for before executing
this rather than using a timeout?

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:315:
showForget_: function(networkProperties) {
@param for networkProperties.

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:326:
showActivate_: function(networkProperties) {
@param

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_proxy_input.html
(right):

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy_input.html:11:
margin-top: -8px;
Can you tell me more about what this is 
doing? Other than what I can read, I mean.
Like is it shifting the container for 
aesthetics or to fix an issue?

[stevenjb, 2016-07-28 22:11:03]

On 2016/07/28 22:03:56, dschuyler wrote:
> Please also add the files to the 
> compiled_resources.gyp so they get compiled
> (such as internet_detail_page.js).
> 

All files should be in compiuled_resources2.gyp, what apepars to be missing?

[dschuyler, 2016-07-28 22:15:28]

On 2016/07/28 22:11:03, stevenjb wrote:
> On 2016/07/28 22:03:56, dschuyler wrote:
> > Please also add the files to the 
> > compiled_resources.gyp so they get compiled
> > (such as internet_detail_page.js).
> > 
> 
> All files should be in compiuled_resources2.gyp, what apepars to be missing?

My mistake, you're right. Hmm, I wonder why the missing
@param for networkProperties wasn't caught by the compiler
(though I'm assuming the compiler was run).

[stevenjb, 2016-07-28 22:15:50]

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.html
(right):

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.html:83:
Forget
On 2016/07/28 22:03:55, dschuyler wrote:
> I think we should $i18n{} the network settings
> soon; and I don't want to muddle this CL with 
> changing all of them, but can this entry be 
> $i18n?

It's coming soon I promise. I'd really rather not do just this tiny bit.

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:134:
}.bind(this));
On 2016/07/28 22:03:55, dschuyler wrote:
> setTimeout and async come up as problems often
> enough that I'd like to ask if there is another
> way to handle this in a more bulletproof way?
> Is there an event to watch for before executing
> this rather than using a timeout?

I tried many things, but nothing else worked reliably. I'm open to suggestions.
I can also ask Michael for suggestions when I am back in SF next week.

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:315:
showForget_: function(networkProperties) {
On 2016/07/28 22:03:55, dschuyler wrote:
> @param for networkProperties.

Not needed for declared properties. Closure is smart enough to figure it out.
Demitri and I discussed this previously and agreed that it's much simpler
without the @param entries for declared properties, but we can discuss this at
Friday's standup if you're concerned.

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:326:
showActivate_: function(networkProperties) {
On 2016/07/28 22:03:55, dschuyler wrote:
> @param

Acknowledged.

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_proxy_input.html
(right):

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy_input.html:11:
margin-top: -8px;
On 2016/07/28 22:03:55, dschuyler wrote:
> Can you tell me more about what this is 
> doing? Other than what I can read, I mean.
> Like is it shifting the container for 
> aesthetics or to fix an issue?

Yes, it is realigning the paper input container (which has massive margins by
default) to match the mocks.

[dschuyler, 2016-07-29 23:13:31]

lgtm

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:134:
}.bind(this));
On 2016/07/28 22:15:50, stevenjb wrote:
> On 2016/07/28 22:03:55, dschuyler wrote:
> > setTimeout and async come up as problems often
> > enough that I'd like to ask if there is another
> > way to handle this in a more bulletproof way?
> > Is there an event to watch for before executing
> > this rather than using a timeout?
> 
> I tried many things, but nothing else worked reliably. I'm open to
suggestions.
> I can also ask Michael for suggestions when I am back in SF next week.

Based on the conversation in the stand-up this morning,
setTimeout is more acceptable that I realized. I do wish
for a better way though.

[stevenjb, 2016-08-02 23:40:34]

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/internet_detail_page.js
(right):

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:134:
}.bind(this));
On 2016/07/29 23:13:31, dschuyler wrote:
> On 2016/07/28 22:15:50, stevenjb wrote:
> > On 2016/07/28 22:03:55, dschuyler wrote:
> > > setTimeout and async come up as problems often
> > > enough that I'd like to ask if there is another
> > > way to handle this in a more bulletproof way?
> > > Is there an event to watch for before executing
> > > this rather than using a timeout?
> > 
> > I tried many things, but nothing else worked reliably. I'm open to
> suggestions.
> > I can also ask Michael for suggestions when I am back in SF next week.
> 
> Based on the conversation in the stand-up this morning,
> setTimeout is more acceptable that I realized. I do wish
> for a better way though.

Acknowledged.

https://codereview.chromium.org/2188163003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/internet_detail_page.js:315:
showForget_: function(networkProperties) {
On 2016/07/28 22:15:50, stevenjb wrote:
> On 2016/07/28 22:03:55, dschuyler wrote:
> > @param for networkProperties.
> 
> Not needed for declared properties. Closure is smart enough to figure it out.
> Demitri and I discussed this previously and agreed that it's much simpler
> without the @param entries for declared properties, but we can discuss this at
> Friday's standup if you're concerned.

Now using this.networkProperties, parameter removed.

[stevenjb, 2016-08-02 23:40:41]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-08-02 23:40:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2188163003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-02 23:41:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 01:00:31]

Description was changed from

==========
MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Fixes a minor idl error causing console errors
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=asargant@ for trivial idl change
==========

to

==========
MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Fixes a minor idl error causing console errors
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=asargant@ for trivial idl change
==========

[commit-bot: I haz the power, 2016-08-03 01:00:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-03 01:03:43]

Description was changed from

==========
MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Fixes a minor idl error causing console errors
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=asargant@ for trivial idl change
==========

to

==========
MD Settings: Internet: Add 'forget' button, more fixes.

This CL:
* Adds a 'forget' button to match the UX design.
* Fixes the proxy input layout.
* Fixes the spinner layout.
* Fixes a minor idl error causing console errors
* Causes the details page to close if navigated to
  without a vlaid guid (e.g. after restart with the
  detail page open).

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=asargant@ for trivial idl change

Committed: https://crrev.com/fec4adcb237c41d8c6c1c787ba87014263d3c29f
Cr-Commit-Position: refs/heads/master@{#409410}
==========

[commit-bot: I haz the power, 2016-08-03 01:03:45]

Patchset 4 (id:??) landed as
https://crrev.com/fec4adcb237c41d8c6c1c787ba87014263d3c29f
Cr-Commit-Position: refs/heads/master@{#409410}