Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: src/parsing/preparser.h

Issue 2188153002: Speed up parsing w/ grammar shortcut. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix PreParserTraits::EmptyExpression Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/parsing/parser-base.h ('K') | « src/parsing/parser-base.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/preparser.h
diff --git a/src/parsing/preparser.h b/src/parsing/preparser.h
index 280f1df5f855c4e096b926a342c1d71d43072367..ca5c182c685c7a506087553878261a50808512af 100644
--- a/src/parsing/preparser.h
+++ b/src/parsing/preparser.h
@@ -200,10 +200,20 @@ class PreParserExpression {
ExpressionTypeField::encode(kNoTemplateTagExpression));
}
+ static PreParserExpression Empty() {
+ return PreParserExpression(TypeField::encode(kExpression) |
+ ExpressionTypeField::encode(kEmptyExpression));
+ }
+
bool IsIdentifier() const {
return TypeField::decode(code_) == kIdentifierExpression;
}
+ bool IsEmptyExpression() const {
+ return TypeField::decode(code_) == kExpression &&
+ ExpressionTypeField::decode(code_) == kEmptyExpression;
+ }
+
PreParserIdentifier AsIdentifier() const {
DCHECK(IsIdentifier());
return PreParserIdentifier(IdentifierTypeField::decode(code_));
@@ -316,7 +326,8 @@ class PreParserExpression {
kCallEvalExpression,
kSuperCallReference,
kNoTemplateTagExpression,
- kAssignment
+ kAssignment,
+ kEmptyExpression
};
explicit PreParserExpression(uint32_t expression_code)
@@ -334,7 +345,7 @@ class PreParserExpression {
// The rest of the bits are interpreted depending on the value
// of the Type field, so they can share the storage.
- typedef BitField<ExpressionType, TypeField::kNext, 3> ExpressionTypeField;
+ typedef BitField<ExpressionType, TypeField::kNext, 4> ExpressionTypeField;
typedef BitField<bool, TypeField::kNext, 1> IsUseStrictField;
typedef BitField<PreParserIdentifier::Type, TypeField::kNext, 10>
IdentifierTypeField;
@@ -662,6 +673,10 @@ class PreParserTraits {
return expression.IsIdentifier();
}
+ static bool IsEmptyExpression(PreParserExpression expression) {
+ return expression.IsEmptyExpression();
+ }
+
static PreParserIdentifier AsIdentifier(PreParserExpression expression) {
return expression.AsIdentifier();
}
@@ -772,7 +787,7 @@ class PreParserTraits {
return PreParserIdentifier::Default();
}
static PreParserExpression EmptyExpression() {
- return PreParserExpression::Default();
+ return PreParserExpression::Empty();
}
static PreParserExpression EmptyLiteral() {
return PreParserExpression::Default();
« src/parsing/parser-base.h ('K') | « src/parsing/parser-base.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698