src/parsing/parser.cc - Issue 2188153002: Speed up parsing w/ grammar shortcut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.cc

Issue 2188153002: Speed up parsing w/ grammar shortcut. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix PreParserTraits::EmptyExpression Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parser.cc

diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc

index dcdc16b03823e170f8e0050d6c804a26dc1fa8ac..9665aa32bcdc9dee85a5a504ba7dbbd4386b8959 100644

--- a/src/parsing/parser.cc

+++ b/src/parsing/parser.cc

@@ -395,6 +395,9 @@ bool ParserTraits::IsIdentifier(Expression* expression) {

return operand != NULL && !operand->is_this();

}

+bool ParserTraits::IsEmptyExpression(Expression* expression) {

+ return expression == nullptr;

void ParserTraits::PushPropertyName(FuncNameInferrer* fni,

Expression* expression) {