Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2188063003: MD Settings: Fix runtime error when visiting "manage passwords" page. (Closed)

Created:
4 years, 4 months ago by dpapad
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, tsergeant, Jeremy Klein, rictic_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix runtime error when visiting "manage passwords" page. BUG=632432 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/36579b0bc9520e57ed45539d3f82d668d9c2dc2b Cr-Commit-Position: refs/heads/master@{#408513}

Patch Set 1 #

Patch Set 2 : fix compiler error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_page/settings_subpage_search.js View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dpapad
4 years, 4 months ago (2016-07-28 21:16:06 UTC) #6
Dan Beam
I guess polymer pass/closure don't know how to combine @abstract and @polymerBehavio yet, eh? maybe ...
4 years, 4 months ago (2016-07-28 22:40:40 UTC) #9
Dan Beam
@polymerBehavior** lgtm
4 years, 4 months ago (2016-07-28 22:40:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188063003/20001
4 years, 4 months ago (2016-07-28 23:06:51 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 23:55:50 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 23:57:28 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36579b0bc9520e57ed45539d3f82d668d9c2dc2b
Cr-Commit-Position: refs/heads/master@{#408513}

Powered by Google App Engine
This is Rietveld 408576698