ClientConnection Unittest memory leak fixed

components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h"
 
 #ifdef OS_WIN
 #include <winsock2.h>
 #else
 #include <netinet/in.h>
 #endif
 
 #include <string.h>
 
 #include <algorithm>
 
 #include "base/logging.h"
 
 namespace proximity_auth {
 namespace weave {
 
 // static.
-BluetoothLowEnergyWeavePacketGenerator::Factory*
+std::shared_ptr<BluetoothLowEnergyWeavePacketGenerator::Factory>

[Kyle Horimoto, 2016/08/03 18:24:06]

Now that you're using a class instead of a pointer, this assignment is
unnecessary. shared_ptr initializes its managed pointer to nullptr.

     BluetoothLowEnergyWeavePacketGenerator::Factory::factory_instance_ =
         nullptr;
 
 // static.
 std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator>
 BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance() {
-  if (factory_instance_ == nullptr) {
-    factory_instance_ = new Factory();
+  if (!factory_instance_) {

[Kyle Horimoto, 2016/08/02 00:04:45]

nit: Please keep the == nullptr comparison. This is more type-safe than
comparing with NULL. Same in other class.

[jingxuy, 2016/08/03 18:04:38]

I had the same question. The pointer is not a raw pointer but a shared pointer.
I looked up how to check for null for shared_ptr and apparently bool is supposed
to be the right way.

http://www.cplusplus.com/reference/memory/shared_ptr/operator%20bool/

[Kyle Horimoto, 2016/08/03 18:24:06]

I meant to use `if (factory_instance_.get() == nullptr)`, not direct comparison.
But sure, this is fine too.

+    factory_instance_.reset(new Factory());
   }
   return factory_instance_->BuildInstance();
 }
 
 // static.
 void BluetoothLowEnergyWeavePacketGenerator::Factory::SetInstanceForTesting(
-    Factory* factory) {
+    std::shared_ptr<Factory> factory) {
   factory_instance_ = factory;
 }
 
 std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator>
 BluetoothLowEnergyWeavePacketGenerator::Factory::BuildInstance() {
   return std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator>(
       new BluetoothLowEnergyWeavePacketGenerator());
 }
 
 BluetoothLowEnergyWeavePacketGenerator::BluetoothLowEnergyWeavePacketGenerator()
@@ skipping 143 matching lines @@
   DCHECK(packet);
   DCHECK(!packet->empty());
 
   // Last bit is the bit 2 of the packet's first byte and set it to 1.
   packet->at(0) = packet->at(0) | (1 << 2);
 }
 
 }  // namespace weave
 
 }  // namespace proximity_auth