Collect metrics for hyphenation dictionary

Collect metrics for hyphenation dictionary

This patch is to collect metrics for hyphenation dictionary on Android
dev channel by always opening the dictionary in the line breaker.

This patch will be reverted after the branch so that it should not be
turned on for other channels.

BUG=605840
Committed: https://crrev.com/58b52fa7122127737cf15c8dd952f443d9d8b667
Cr-Commit-Position: refs/heads/master@{#410574}

[kojii, 2016-07-28 07:25:11]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 07:25:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-28 07:30:53]

Description was changed from

==========
turn-on-hyphenation

BUG=
==========

to

==========
Temporary turn on CSSHyphens to collect metrics on Android dev channel

This patch temporarily turns on CSSHyphens to collect metrics for
dictionary IPC, only for an Android dev channel.

This patch will be reverted after the branch so that it should not be
turned on for other channels.

BUG=605840
==========

[kojii, 2016-07-28 07:31:43]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2016-07-28 07:31:44]

PTAL.

Will discuss with amineer@ for when to land and when to revert.

[commit-bot: I haz the power, 2016-07-28 08:27:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 08:27:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2016-07-28 10:07:59]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 10:08:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 12:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 12:57:48]

Dry run: This issue passed the CQ dry run.

[eae, 2016-07-28 17:05:57]

LGTM!

[kojii, 2016-07-29 07:01:28]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 07:01:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-29 07:03:26]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 07:03:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-07-29 07:03:40]

Patchset #3 (id:40001) has been deleted

[kojii, 2016-07-29 07:31:20]

Description was changed from

==========
Temporary turn on CSSHyphens to collect metrics on Android dev channel

This patch temporarily turns on CSSHyphens to collect metrics for
dictionary IPC, only for an Android dev channel.

This patch will be reverted after the branch so that it should not be
turned on for other channels.

BUG=605840
==========

to

==========
Collect metrics for hyphenation dictionary

This patch is to collect metrics for hyphenation dictionary on Android
dev channel by always opening the dictionary in the line breaker.

This patch will be reverted after the branch so that it should not be
turned on for other channels.

BUG=605840
==========

[kojii, 2016-07-29 07:32:42]

Changed the way we do this after talking to tkent@, as turning on will expose
"hyphens" property to public and require approval from API owners.

The suggestion was just to open dictionaries without enabling the hyphenation.
PS3 does this.

Hope you're still ok with this, please let me know if any.

[commit-bot: I haz the power, 2016-07-29 08:07:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 08:07:31]

Dry run: This issue passed the CQ dry run.

[eae, 2016-07-29 17:09:13]

Thanks for the update.

LGTM

[kojii, 2016-07-29 19:31:58]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 19:32:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 20:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 20:42:58]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-08-09 03:20:19]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-08-09 03:20:20]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2188043004/#ps80001
(title: "Add #if OS(ANDROID)")

[commit-bot: I haz the power, 2016-08-09 03:20:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 04:56:29]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-08-09 04:57:52]

Description was changed from

==========
Collect metrics for hyphenation dictionary

This patch is to collect metrics for hyphenation dictionary on Android
dev channel by always opening the dictionary in the line breaker.

This patch will be reverted after the branch so that it should not be
turned on for other channels.

BUG=605840
==========

to

==========
Collect metrics for hyphenation dictionary

This patch is to collect metrics for hyphenation dictionary on Android
dev channel by always opening the dictionary in the line breaker.

This patch will be reverted after the branch so that it should not be
turned on for other channels.

BUG=605840

Committed: https://crrev.com/58b52fa7122127737cf15c8dd952f443d9d8b667
Cr-Commit-Position: refs/heads/master@{#410574}
==========

[commit-bot: I haz the power, 2016-08-09 04:57:52]

Patchset 4 (id:??) landed as
https://crrev.com/58b52fa7122127737cf15c8dd952f443d9d8b667
Cr-Commit-Position: refs/heads/master@{#410574}

[kojii, 2016-08-16 09:37:08]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/2244413003/ by kojii@chromium.org.

The reason for reverting is: Reverting as this experiment shipped in dev and we
started to get the data..