Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2188043002: make use of existing gn args in net/BUILD.gn (Closed)

Created:
4 years, 4 months ago by Mostyn Bramley-Moore
Modified:
4 years, 4 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

make use of existing gn args in net/BUILD.gn BUG=632297 Committed: https://crrev.com/75e8d631af691f5607637bdf7fa3eb3fe9b98c88 Cr-Commit-Position: refs/heads/master@{#409209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mostyn Bramley-Moore
@bengr: please take a look at this small GN cleanup.
4 years, 4 months ago (2016-07-27 23:10:00 UTC) #4
bengr
lgtm
4 years, 4 months ago (2016-08-01 16:33:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188043002/1
4 years, 4 months ago (2016-08-02 14:57:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 16:47:13 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 16:49:15 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/75e8d631af691f5607637bdf7fa3eb3fe9b98c88
Cr-Commit-Position: refs/heads/master@{#409209}

Powered by Google App Engine
This is Rietveld 408576698