Cleanup vm_service library loading.

runtime/bin/vmservice_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/vmservice_impl.h"
 
 #include "include/dart_api.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
@@ skipping 24 matching lines @@
 
 #define SHUTDOWN_ON_ERROR(handle)                               \
   if (Dart_IsError(handle)) {                                   \
     error_msg_ = strdup(Dart_GetError(handle));                 \
     Dart_ExitScope();                                           \
     Dart_ShutdownIsolate();                                     \
     return false;                                               \
   }
 
 #define kLibraryResourceNamePrefix "/vmservice"
-static const char* kLibraryScriptResourceName =
+static const char* kVMServiceIOLibraryScriptResourceName =
+    kLibraryResourceNamePrefix "/vmservice_io.dart";
+static const char* kVMServiceLibraryName =
     kLibraryResourceNamePrefix "/vmservice.dart";
-static const char* kLibrarySourceResourceNames[] = {
-    kLibraryResourceNamePrefix "/constants.dart",
-    kLibraryResourceNamePrefix "/resources.dart",
-    kLibraryResourceNamePrefix "/running_isolate.dart",
-    kLibraryResourceNamePrefix "/running_isolates.dart",
-    kLibraryResourceNamePrefix "/server.dart",
-    kLibraryResourceNamePrefix "/service_request.dart",
-    kLibraryResourceNamePrefix "/service_request_router.dart",
-    kLibraryResourceNamePrefix "/vmservice_io.dart",
-    NULL
-};
 
 #define kClientResourceNamePrefix "/client/web/out"
 
 Dart_Isolate VmService::isolate_ = NULL;
 Dart_Port VmService::port_ = ILLEGAL_PORT;
 dart::Monitor* VmService::monitor_ = NULL;
 const char* VmService::error_msg_ = NULL;
 
 // These must be kept in sync with vmservice/constants.dart
 #define VM_SERVICE_ISOLATE_STARTUP_MESSAGE_ID 1
@@ skipping 35 matching lines @@
 
   Dart_EnterScope();
 
   if (snapshot_buffer != NULL) {
     // Setup the native resolver as the snapshot does not carry it.
     Builtin::SetNativeResolver(Builtin::kBuiltinLibrary);
     Builtin::SetNativeResolver(Builtin::kIOLibrary);
   }
 
   // Set up the library tag handler for this isolate.
-  Dart_Handle result = Dart_SetLibraryTagHandler(DartUtils::LibraryTagHandler);
+  Dart_Handle result = Dart_SetLibraryTagHandler(LibraryTagHandler);
   SHUTDOWN_ON_ERROR(result);
 
   // Load the specified application script into the newly created isolate.
 
   // Prepare builtin and its dependent libraries for use to resolve URIs.
   // The builtin library is part of the core snapshot and would already be
   // available here in the case of script snapshot loading.
   Dart_Handle builtin_lib =
       Builtin::LoadAndCheckLibrary(Builtin::kBuiltinLibrary);
   SHUTDOWN_ON_ERROR(builtin_lib);
 
   // Prepare for script loading by setting up the 'print' and 'timer'
   // closures and setting up 'package root' for URI resolution.
   result = DartUtils::PrepareForScriptLoading("", builtin_lib);
   SHUTDOWN_ON_ERROR(result);
 
   {
     // Load source into service isolate.
-    Dart_Handle library = LoadScript(kLibraryScriptResourceName);
+    Dart_Handle library = LoadScript(kVMServiceIOLibraryScriptResourceName);
     SHUTDOWN_ON_ERROR(library);
-    result = LoadSources(library, kLibrarySourceResourceNames);
-    SHUTDOWN_ON_ERROR(result);
   }
 
   // Make the isolate runnable so that it is ready to handle messages.
   Dart_ExitScope();
   Dart_ExitIsolate();
 
   bool retval = Dart_IsolateMakeRunnable(isolate_);
   if (!retval) {
     Dart_EnterIsolate(isolate_);
     Dart_ShutdownIsolate();
     error_msg_ = "Invalid isolate state - Unable to make it runnable.";
     return false;
   }
 
   Dart_EnterIsolate(isolate_);
   Dart_EnterScope();
 
 
   Dart_Handle library = Dart_RootLibrary();
   // Set requested port.
   DartUtils::SetIntegerField(library, "_port", server_port);
-  // Install native resolver.
-  result = Dart_SetNativeResolver(library, VmServiceNativeResolver);
-  SHUTDOWN_ON_ERROR(result);
   result = Dart_Invoke(library, DartUtils::NewString("main"), 0, NULL);
   SHUTDOWN_ON_ERROR(result);
 
   result = LoadResources(library);
   SHUTDOWN_ON_ERROR(result);
   result = Dart_CompileAll();
   SHUTDOWN_ON_ERROR(result);
 
   port_ = Dart_GetMainPortId();
 
@@ skipping 17 matching lines @@
 Dart_Port VmService::port() {
   return port_;
 }
 
 
 bool VmService::IsRunning() {
   return port_ != ILLEGAL_PORT;
 }
 
 
+Dart_Handle VmService::GetSource(const char* name) {
+  const char* vmservice_source = NULL;
+  int r = Resources::ResourceLookup(name, &vmservice_source);
+  ASSERT(r != Resources::kNoSuchInstance);
+  return Dart_NewStringFromCString(vmservice_source);
+}
+
+
 Dart_Handle VmService::LoadScript(const char* name) {
   Dart_Handle url = Dart_NewStringFromCString(name);
-  const char* vmservice_source = NULL;
-  int r = Resources::ResourceLookup(name, &vmservice_source);
-  ASSERT(r != Resources::kNoSuchInstance);
-  Dart_Handle source = Dart_NewStringFromCString(vmservice_source);
+  Dart_Handle source = GetSource(name);
   return Dart_LoadScript(url, source, 0, 0);
 }
 
 
 Dart_Handle VmService::LoadSource(Dart_Handle library, const char* name) {
   Dart_Handle url = Dart_NewStringFromCString(name);
-  const char* vmservice_source = NULL;
-  int r = Resources::ResourceLookup(name, &vmservice_source);
-  if (r == Resources::kNoSuchInstance) {
-    printf("Can't find %s\n", name);
-  }
-  ASSERT(r != Resources::kNoSuchInstance);
-  Dart_Handle source = Dart_NewStringFromCString(vmservice_source);
+  Dart_Handle source = GetSource(name);
   return Dart_LoadSource(library, url, source);
 }
 
 
 Dart_Handle VmService::LoadSources(Dart_Handle library, const char* names[]) {
   Dart_Handle result = Dart_Null();
   for (int i = 0; names[i] != NULL; i++) {
     result = LoadSource(library, names[i]);
     if (Dart_IsError(result)) {
       break;
@@ skipping 52 matching lines @@
       result = LoadResource(library, path, kClientResourceNamePrefix);
       if (Dart_IsError(result)) {
         break;
       }
     }
   }
   return result;
 }
 
 
+Dart_Handle VmService::LibraryTagHandler(Dart_LibraryTag tag,
+                                         Dart_Handle library,
+                                         Dart_Handle url) {
+  if (!Dart_IsLibrary(library)) {
+    return Dart_Error("not a library");
+  }
+  if (!Dart_IsString(url)) {
+    return Dart_Error("url is not a string");
+  }
+  const char* url_string = NULL;
+  Dart_Handle result = Dart_StringToCString(url, &url_string);
+  if (Dart_IsError(result)) {
+    return result;
+  }
+  Dart_Handle library_url = Dart_LibraryUrl(library);
+  const char* library_url_string = NULL;
+  result = Dart_StringToCString(library_url, &library_url_string);
+  if (Dart_IsError(result)) {
+    return result;
+  }
+  bool is_vm_service_url =
+      (strncmp(kLibraryResourceNamePrefix, url_string,
+               strlen(kLibraryResourceNamePrefix)) == 0);
+  bool is_vm_service_library =
+      (strcmp(kVMServiceLibraryName, url_string) == 0);

[siva, 2013/08/02 21:32:44]

This seems to be computed too eagerly. Is is needed only
if tag is Dart_kImportTag, you could move this down under
that case statement.

Also it might be more readable to have functions
bool IsVMServiceURL(const char* url_string);
bool IsVMServiceLibrary(const char* url_string);
and use them instead.

[Cutch, 2013/08/02 21:39:13]

Done.

+  if (!is_vm_service_url) {
+    // Pass to DartUtils.
+    return DartUtils::LibraryTagHandler(tag, library, url);
+  }
+  switch (tag) {
+    case Dart_kCanonicalizeUrl:
+      // The URL is already canonicalized.
+      return url;
+    break;
+    case Dart_kImportTag: {
+      Dart_Handle source = GetSource(url_string);
+      if (Dart_IsError(source)) {
+        return source;
+      }
+      Dart_Handle lib = Dart_LoadLibrary(url, source);
+      if (Dart_IsError(lib)) {
+        return lib;
+      }
+      if (is_vm_service_library) {
+        // Install native resolver for this library.
+        result = Dart_SetNativeResolver(lib, VmServiceNativeResolver);
+        if (Dart_IsError(result)) {
+          return result;
+        }
+      }
+      return lib;
+    }
+    break;
+    case Dart_kSourceTag: {
+      Dart_Handle source = GetSource(url_string);
+      if (Dart_IsError(source)) {
+        return source;
+      }
+      return Dart_LoadSource(library, url, source);
+    }
+    break;
+    default:
+      UNIMPLEMENTED();
+    break;
+  }
+  UNREACHABLE();
+  return result;
+}
+
+
 void VmService::ThreadMain(uword parameters) {
   ASSERT(Dart_CurrentIsolate() == NULL);
   ASSERT(isolate_ == NULL);
 
   intptr_t server_port = static_cast<intptr_t>(parameters);
   ASSERT(server_port >= 0);
 
   // Lock scope.
   {
     MonitorLocker ml(monitor_);
@@ skipping 146 matching lines @@
     if (!strcmp(function_name, entry.name) &&
         (num_arguments == entry.num_arguments)) {
       return entry.function;
     }
   }
   return NULL;
 }
 
 }  // namespace bin
 }  // namespace dart