Remove the TableRowNSImageCache.

Remove the TableRowNSImageCache.

It's only used by the task manager, it doesn't help much, it uses NSPointerArray which is a class intended for GC (which is obsolete), and it just complicates the flow.

BUG=528486
TEST=none

Committed: https://crrev.com/0cfd69c216ab692ef68164697e11f203652f6428
Cr-Commit-Position: refs/heads/master@{#408262}

[Avi (use Gerrit), 2016-07-27 21:01:06]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 21:01:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-07-27 21:02:59]

avi@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-07-27 21:08:46]

https://codereview.chromium.org/2187993002/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (left):

https://codereview.chromium.org/2187993002/diff/1/chrome/chrome_browser_ui.gy...
chrome/chrome_browser_ui.gypi:1272:
'browser/ui/cocoa/table_row_nsimage_cache.h',
Gotta suck this out of the .gn file too now.

[Avi (use Gerrit), 2016-07-27 21:21:49]

https://codereview.chromium.org/2187993002/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (left):

https://codereview.chromium.org/2187993002/diff/1/chrome/chrome_browser_ui.gy...
chrome/chrome_browser_ui.gypi:1272:
'browser/ui/cocoa/table_row_nsimage_cache.h',
On 2016/07/27 21:08:45, Mark Mentovai wrote:
> Gotta suck this out of the .gn file too now.

Which gn file? chrome/browser/ui/BUILD.gn does a gypi_to_gn.py import of
chrome_browser_ui.gypi (see
https://cs.chromium.org/chromium/src/chrome/browser/ui/BUILD.gn?rcl=0&l=11 ) so
this should be all I need.

[commit-bot: I haz the power, 2016-07-27 21:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 21:36:58]

Dry run: This issue passed the CQ dry run.

[Mark Mentovai, 2016-07-27 21:42:43]

Gross, I didn’t realize that the gypi-to-gn thing was still being done. LGTM.

[Avi (use Gerrit), 2016-07-27 21:56:52]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-07-27 21:57:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 22:07:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 22:07:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Avi (use Gerrit), 2016-07-27 23:02:54]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:03:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 23:06:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-27 23:10:18]

Description was changed from

==========
Remove the TableRowNSImageCache.

It's only used by the task manager, it doesn't help much, it uses NSPointerArray
which is a class intended for GC (which is obsolete), and it just complicates
the flow.

BUG=528486
TEST=none
==========

to

==========
Remove the TableRowNSImageCache.

It's only used by the task manager, it doesn't help much, it uses NSPointerArray
which is a class intended for GC (which is obsolete), and it just complicates
the flow.

BUG=528486
TEST=none

Committed: https://crrev.com/0cfd69c216ab692ef68164697e11f203652f6428
Cr-Commit-Position: refs/heads/master@{#408262}
==========

[commit-bot: I haz the power, 2016-07-27 23:10:20]

Patchset 1 (id:??) landed as
https://crrev.com/0cfd69c216ab692ef68164697e11f203652f6428
Cr-Commit-Position: refs/heads/master@{#408262}