[Courgette] Replace QSufSort with libdivsufsort.

[Courgette] Replace QSufSort with libdivsufsort.

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885
Committed: https://crrev.com/4efc71b655733edfe3373cac6d547dbc0d623bae
Cr-Commit-Position: refs/heads/master@{#409326}

[huangs, 2016-07-27 22:42:48]

Description was changed from

==========
!# Enter a description of the change.
[Courgette] Replace QSufSort with libdivsufsort

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885
==========

to

==========
[Courgette] Replace QSufSort with libdivsufsort

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885
==========

[huangs, 2016-07-27 22:43:12]

Description was changed from

==========
[Courgette] Replace QSufSort with libdivsufsort

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885
==========

to

==========
[Courgette] Replace QSufSort with libdivsufsort.

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885
==========

[huangs, 2016-07-27 22:43:13]

huangs@chromium.org changed reviewers:
+ chrisha@chromium.org

[huangs, 2016-07-27 22:44:16]

PTAL for early review.  Will do detailed experiments before committing (likely
next week).

[huangs, 2016-08-01 21:55:21]

Experiment confirms average 25% reduction in Courgette-gen time. It also enables
32-bit courgette.exe to process 64-bit Chrome (used to die from OOM).  See
http://crbug.com/608885#c16 for details.

Formally requesting review, PTAL. Thanks!

[chrisha, 2016-08-02 15:26:00]

lgtm!

https://codereview.chromium.org/2187953003/diff/1/courgette/third_party/bsdif...
File courgette/third_party/bsdiff/bsdiff_create.cc (right):

https://codereview.chromium.org/2187953003/diff/1/courgette/third_party/bsdif...
courgette/third_party/bsdiff/bsdiff_create.cc:41: //               --Stephen
Adams <sra@chromium.org>
Fix indent while you're here?

[huangs, 2016-08-02 18:32:53]

huangs@chromium.org changed reviewers:
+ wfh@chromium.org

[huangs, 2016-08-02 18:32:53]

Updated. Adding wfh@ for review, PTAL, and see http://crbug.com/608885#c16 for
experiment.  Thanks!

https://codereview.chromium.org/2187953003/diff/1/courgette/third_party/bsdif...
File courgette/third_party/bsdiff/bsdiff_create.cc (right):

https://codereview.chromium.org/2187953003/diff/1/courgette/third_party/bsdif...
courgette/third_party/bsdiff/bsdiff_create.cc:41: //               --Stephen
Adams <sra@chromium.org>
On 2016/08/02 15:26:00, chrisha (slow) wrote:
> Fix indent while you're here?

Done.

[huangs, 2016-08-02 18:33:12]

The CQ bit was checked by huangs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:33:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 19:56:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 19:56:13]

Dry run: This issue passed the CQ dry run.

[Will Harris, 2016-08-02 20:34:35]

lgtm yay!

[huangs, 2016-08-02 21:11:21]

Thanks. Committing!

[huangs, 2016-08-02 21:11:26]

The CQ bit was checked by huangs@chromium.org

[huangs, 2016-08-02 21:11:26]

The patchset sent to the CQ was uploaded after l-g-t-m from chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2187953003/#ps20001
(title: "Fix spacing.")

[commit-bot: I haz the power, 2016-08-02 21:12:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 21:28:30]

Description was changed from

==========
[Courgette] Replace QSufSort with libdivsufsort.

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885
==========

to

==========
[Courgette] Replace QSufSort with libdivsufsort.

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885
==========

[commit-bot: I haz the power, 2016-08-02 21:28:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-02 21:31:58]

Description was changed from

==========
[Courgette] Replace QSufSort with libdivsufsort.

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885
==========

to

==========
[Courgette] Replace QSufSort with libdivsufsort.

Last step of the effort to get Courgette to use libdivsufsort.

BUG=608885

Committed: https://crrev.com/4efc71b655733edfe3373cac6d547dbc0d623bae
Cr-Commit-Position: refs/heads/master@{#409326}
==========

[commit-bot: I haz the power, 2016-08-02 21:32:00]

Patchset 2 (id:??) landed as
https://crrev.com/4efc71b655733edfe3373cac6d547dbc0d623bae
Cr-Commit-Position: refs/heads/master@{#409326}