mash: Migrate ShelfButton* to wm common types

mash: Migrate ShelfButton* to wm common types

* Convert from Shelf to WmShelf
* Move to //ash/common/shelf

BUG=632071
TEST=ash_unittests

Committed: https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b
Cr-Commit-Position: refs/heads/master@{#408224}

[James Cook, 2016-07-27 19:41:13]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 19:41:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-27 19:42:59]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-27 19:43:00]

msw, please take a look.

https://codereview.chromium.org/2187953002/diff/1/ash/common/shelf/wm_shelf.h
File ash/common/shelf/wm_shelf.h (right):

https://codereview.chromium.org/2187953002/diff/1/ash/common/shelf/wm_shelf.h...
ash/common/shelf/wm_shelf.h:97: virtual ShelfView* GetShelfViewForTesting() = 0;
I did this because I wanted to move the unit test with the code it tests, and I
didn't want to introduce a WmShelfTestApi since (a) WmShelfAura doesn't have
access to ShelfView and (b) I'm not yet sure how unit tests will work after the
mus flip.

[msw, 2016-07-27 20:12:34]

lgtm

https://codereview.chromium.org/2187953002/diff/1/ash/common/shelf/wm_shelf.h
File ash/common/shelf/wm_shelf.h (right):

https://codereview.chromium.org/2187953002/diff/1/ash/common/shelf/wm_shelf.h...
ash/common/shelf/wm_shelf.h:97: virtual ShelfView* GetShelfViewForTesting() = 0;
On 2016/07/27 19:43:00, James Cook wrote:
> I did this because I wanted to move the unit test with the code it tests, and
I
> didn't want to introduce a WmShelfTestApi since (a) WmShelfAura doesn't have
> access to ShelfView and (b) I'm not yet sure how unit tests will work after
the
> mus flip.

Acknowledged.

[James Cook, 2016-07-27 20:14:49]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-07-27 20:14:56]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:15:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 20:18:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-27 20:22:57]

Description was changed from

==========
mash: Migrate ShelfButton* to wm common types

* Convert from Shelf to WmShelf
* Move to //ash/common/shelf

BUG=632071
TEST=ash_unittests
==========

to

==========
mash: Migrate ShelfButton* to wm common types

* Convert from Shelf to WmShelf
* Move to //ash/common/shelf

BUG=632071
TEST=ash_unittests

Committed: https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b
Cr-Commit-Position: refs/heads/master@{#408224}
==========

[commit-bot: I haz the power, 2016-07-27 20:22:58]

Patchset 1 (id:??) landed as
https://crrev.com/a8274f0b783fa6272dd093f2c76b47a624bb036b
Cr-Commit-Position: refs/heads/master@{#408224}