Issue 2187903003: upload_bench_results - fix GS upload path.

Issue 2187903003: upload_bench_results - fix GS upload path. (Closed)

Created:
4 years, 4 months ago by jcgregorio

Modified:
4 years, 4 months ago

Reviewers:
borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

upload_bench_results - fix GS upload path. _UploadJSONResults does '/'.join() so the trailing / is unnecessary. BUG=skia: R=borenet GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187903003 Committed: https://skia.googlesource.com/skia/+/4b9ebab04d7134a5cddffedeb0470b3fd7743d78

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	infra/bots/recipe_modules/skia/resources/upload_bench_results.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (4 generated)

jcgregorio

On 2016/07/27 at 20:41:55, borenet wrote: > LGTM. Does posixpath.join() prevent the double slashes? I ...

4 years, 4 months ago (2016-07-27 20:48:13 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187903003/1

4 years, 4 months ago (2016-07-27 20:48:17 UTC) #7

commit-bot: I haz the power

4 years, 4 months ago (2016-07-27 21:34:09 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4b9ebab04d7134a5cddffedeb0470b3fd7743d78