Move more client network code to //blimp/client/core/session.

Move more client network code to //blimp/client/core/session.

The BlimpClientSession will be going away, so this CL takes part of it
and splits it up into smaller parts and moves them to
//blimp/client/core/session. They will be used by the
BlimpClientContextImpl.

BUG=611097
Committed: https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938
Cr-Commit-Position: refs/heads/master@{#408802}

[nyquist, 2016-07-27 21:57:25]

nyquist@chromium.org changed reviewers:
+ kmarshall@chromium.org

[nyquist, 2016-07-27 21:57:26]

kmarshall: PTAL

[Kevin M, 2016-07-29 18:56:03]

lgtm % nits

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
File blimp/client/core/session/client_network_components.cc (right):

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.cc:28: connection_manager_ =
base::WrapUnique(new ClientConnectionManager(this));
base::MakeUnique

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.cc:74:
network_observer_->OnConnected();
Observer should be triggered at the end of the function

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
File blimp/client/core/session/client_network_components.h (right):

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.h:20: // This class's
functions and destruction must all be invoked on the IO thread
Perhaps we should add some ThreadChecker checks, just to be sure.

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.h:40: void
DropCurrentConnection();
Remove this method and replace references to it with
BrowserConnectionHandler::DropCurrentConnection.

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.h:49:
std::unique_ptr<BrowserConnectionHandler> connection_handler_;
No need to make this a unique_ptr.

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
File blimp/client/core/session/cross_thread_network_event_observer.h (right):

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/cross_thread_network_event_observer.h:19: // Posts
network events to an observer across the IO/UI thread boundary.
NetworkEvents

[nyquist, 2016-07-29 21:07:52]

all done

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
File blimp/client/core/session/client_network_components.cc (right):

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.cc:28: connection_manager_ =
base::WrapUnique(new ClientConnectionManager(this));
On 2016/07/29 18:56:03, Kevin M wrote:
> base::MakeUnique

Done. Nice! Didn't know about this one.

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.cc:74:
network_observer_->OnConnected();
On 2016/07/29 18:56:03, Kevin M wrote:
> Observer should be triggered at the end of the function

Done.

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
File blimp/client/core/session/client_network_components.h (right):

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.h:20: // This class's
functions and destruction must all be invoked on the IO thread
On 2016/07/29 18:56:03, Kevin M wrote:
> Perhaps we should add some ThreadChecker checks, just to be sure.

Done. I didn't pass it in though, so it's just whatever where this class was
constructed from.

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.h:40: void
DropCurrentConnection();
On 2016/07/29 18:56:03, Kevin M wrote:
> Remove this method and replace references to it with
> BrowserConnectionHandler::DropCurrentConnection.

Done.

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/client_network_components.h:49:
std::unique_ptr<BrowserConnectionHandler> connection_handler_;
On 2016/07/29 18:56:03, Kevin M wrote:
> No need to make this a unique_ptr.

Done.

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
File blimp/client/core/session/cross_thread_network_event_observer.h (right):

https://codereview.chromium.org/2187893002/diff/1/blimp/client/core/session/c...
blimp/client/core/session/cross_thread_network_event_observer.h:19: // Posts
network events to an observer across the IO/UI thread boundary.
On 2016/07/29 18:56:03, Kevin M wrote:
> NetworkEvents

Done.

[nyquist, 2016-07-29 21:07:59]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-07-29 21:07:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2187893002/#ps20001
(title: "Addressed nits")

[commit-bot: I haz the power, 2016-07-29 21:08:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2016-07-29 21:37:15]

The CQ bit was unchecked by nyquist@chromium.org

[nyquist, 2016-07-29 22:03:52]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-07-29 22:03:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2187893002/#ps60001
(title: "Add more explanatory comments")

[commit-bot: I haz the power, 2016-07-29 22:04:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 23:22:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-29 23:25:02]

Description was changed from

==========
Move more client network code to //blimp/client/core/session.

The BlimpClientSession will be going away, so this CL takes part of it
and splits it up into smaller parts and moves them to
//blimp/client/core/session. They will be used by the
BlimpClientContextImpl.

BUG=611097
==========

to

==========
Move more client network code to //blimp/client/core/session.

The BlimpClientSession will be going away, so this CL takes part of it
and splits it up into smaller parts and moves them to
//blimp/client/core/session. They will be used by the
BlimpClientContextImpl.

BUG=611097

Committed: https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938
Cr-Commit-Position: refs/heads/master@{#408802}
==========

[commit-bot: I haz the power, 2016-07-29 23:25:04]

Patchset 4 (id:??) landed as
https://crrev.com/14014dc154affce8602b0c81934b8a3718abd938
Cr-Commit-Position: refs/heads/master@{#408802}