Issue 2187833002: PPC: Set CodeRange constants correctly for PPC Linux

Issue 2187833002: PPC: Set CodeRange constants correctly for PPC Linux (Closed)

Created:
4 years, 4 months ago by JaideepBajwa

Modified:
4 years, 4 months ago

Reviewers:
MTBrandyberry, jochen (gone - plz use gerrit), michael_dawson, john.yan, JoranSiu

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

PPC: Set CodeRange constants correctly for PPC Linux The OS page size for PPC linux is 64KB. The page size for paged spaces on PPC linux is set to 4MB. kCodeRangeAreaAlignment is set to OS page size(64KB) and kMinimumCodeRangeSize is set to the size of 3 pages (12MB). This issue was exposed with testcase test-spaces/Regress3540 which used kMinimumCodeRangeSize. R=jochen@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/9b4f8d1951aaeab7bfe38a1d29f47d22f1785142 Cr-Commit-Position: refs/heads/master@{#38180}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/globals.h	View		3 chunks	+13 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

JaideepBajwa

On 2016/07/29 09:51:30, jochen wrote: > lgtm Thanks.

4 years, 4 months ago (2016-07-29 14:02:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187833002/1

4 years, 4 months ago (2016-07-29 14:02:48 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-07-29 14:28:10 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9b4f8d1951aaeab7bfe38a1d29f47d22f1785142
Cr-Commit-Position: refs/heads/master@{#38180}