Issue 218783003: Replace uses of set_map by MigrateToMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218783003: Replace uses of set_map by MigrateToMap. (Closed)

Created:
6 years, 8 months ago by Toon Verwaest

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Replace uses of set_map by MigrateToMap. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20389

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -20 lines)			Patch
	M	src/runtime.cc	View		4 chunks	+23 lines, -20 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with nit: https://codereview.chromium.org/218783003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/218783003/diff/1/src/runtime.cc#newcode2971 src/runtime.cc:2971: function->map()->CopyReplaceDescriptor( Does it make sense to ...

6 years, 8 months ago (2014-03-31 12:52:43 UTC) #2

Toon Verwaest

6 years, 8 months ago (2014-04-01 11:04:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20389 (presubmit successful).

Expand Messages | Collapse Messages