[interpreter] Don't keep postfix result if only visited for effect

[interpreter] Don't keep postfix result if only visited for effect

Remove TODO to perform same optimization as AstGraphBuilder.
When visiting for effect in a postfix count operation, don't
keep the intermediate result of ToNumber.

BUG=v4:4280
LOG=n

Committed: https://crrev.com/27a9b032ab8c569d282c5db366c15b3d339c3513
Cr-Commit-Position: refs/heads/master@{#38101}

[klaasb, 2016-07-27 10:47:14]

The CQ bit was checked by klaasb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 10:47:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 10:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 10:59:35]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9769)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[klaasb, 2016-07-27 11:25:17]

The CQ bit was checked by klaasb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 11:25:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[klaasb, 2016-07-27 11:29:10]

Description was changed from

==========
[interpreter] Don't keep postfix result if effect

Remove TODO to perform same optimization as AstGraphBuilder. When
visiting for effect in a postfix count operation, don't keep the
intermediate result of ToNumber.

BUG=v4:4280
LOG=n
==========

to

==========
[interpreter] Don't keep postfix result if effect

Remove TODO to perform same optimization as AstGraphBuilder.
When visiting for effect in a postfix count operation, don't
keep the intermediate result of ToNumber.

BUG=v4:4280
LOG=n
==========

[klaasb, 2016-07-27 11:29:11]

klaasb@google.com changed reviewers:
+ rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-07-27 11:49:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 11:49:49]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-07-27 13:28:21]

Nice, lgtm, thanks.

[rmcilroy, 2016-07-27 13:29:21]

On 2016/07/27 13:28:21, rmcilroy wrote:
> Nice, lgtm, thanks.

nit - update title and first line of description to be /s/if effect/if only
visited for effect".

[klaasb, 2016-07-27 13:47:01]

Description was changed from

==========
[interpreter] Don't keep postfix result if effect

Remove TODO to perform same optimization as AstGraphBuilder.
When visiting for effect in a postfix count operation, don't
keep the intermediate result of ToNumber.

BUG=v4:4280
LOG=n
==========

to

==========
[interpreter] Don't keep postfix result if only visited for effect

Remove TODO to perform same optimization as AstGraphBuilder.
When visiting for effect in a postfix count operation, don't
keep the intermediate result of ToNumber.

BUG=v4:4280
LOG=n
==========

[klaasb, 2016-07-27 13:47:57]

The CQ bit was checked by klaasb@google.com

[commit-bot: I haz the power, 2016-07-27 13:48:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 13:49:30]

Description was changed from

==========
[interpreter] Don't keep postfix result if only visited for effect

Remove TODO to perform same optimization as AstGraphBuilder.
When visiting for effect in a postfix count operation, don't
keep the intermediate result of ToNumber.

BUG=v4:4280
LOG=n
==========

to

==========
[interpreter] Don't keep postfix result if only visited for effect

Remove TODO to perform same optimization as AstGraphBuilder.
When visiting for effect in a postfix count operation, don't
keep the intermediate result of ToNumber.

BUG=v4:4280
LOG=n
==========

[commit-bot: I haz the power, 2016-07-27 13:49:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 13:52:13]

Description was changed from

==========
[interpreter] Don't keep postfix result if only visited for effect

Remove TODO to perform same optimization as AstGraphBuilder.
When visiting for effect in a postfix count operation, don't
keep the intermediate result of ToNumber.

BUG=v4:4280
LOG=n
==========

to

==========
[interpreter] Don't keep postfix result if only visited for effect

Remove TODO to perform same optimization as AstGraphBuilder.
When visiting for effect in a postfix count operation, don't
keep the intermediate result of ToNumber.

BUG=v4:4280
LOG=n

Committed: https://crrev.com/27a9b032ab8c569d282c5db366c15b3d339c3513
Cr-Commit-Position: refs/heads/master@{#38101}
==========

[commit-bot: I haz the power, 2016-07-27 13:52:14]

Patchset 2 (id:??) landed as
https://crrev.com/27a9b032ab8c569d282c5db366c15b3d339c3513
Cr-Commit-Position: refs/heads/master@{#38101}