Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2187753002: Revert of [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. (patchset #1 id:1 of https://codereview.chromium.org/2183963003/ ) Reason for revert: This is causing failures on Mac Build. See: https://build.chromium.org/p/chromium/builders/Mac/builds/18011 Original issue's description: > [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build. > > BUG=631833 > R=erikchen@chromium.org > > Committed: https://crrev.com/1905fc8c9e06650f75433a78e87e26477873da54 > Cr-Commit-Position: refs/heads/master@{#407988} TBR=erikchen@chromium.org,dpranke@google.com,dpranke@chromium.org,rsesek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631833 Committed: https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78 Cr-Commit-Position: refs/heads/master@{#408006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/BUILD.gn View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tsergeant
Created Revert of [Mac/GN] Only specify a rpath for //chrome:chrome_helper_app in the component build.
4 years, 4 months ago (2016-07-27 01:17:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187753002/1
4 years, 4 months ago (2016-07-27 01:18:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 01:19:09 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 01:22:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95f93fb96fd66efe1a1ac330265124f84069ab78
Cr-Commit-Position: refs/heads/master@{#408006}

Powered by Google App Engine
This is Rietveld 408576698