Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: remoting/client/jni/jni_display_handler.h

Issue 2187723002: [Remoting Android] Refactor CursorShapeStubProxy from JniDisplayHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/jni/jni_display_handler.h
diff --git a/remoting/client/jni/jni_display_handler.h b/remoting/client/jni/jni_display_handler.h
index 2f80488567db1701f408ff6422190c25bb7d8184..f81bde92a1a656d0c7f3bb9b3738345f4d94074f 100644
--- a/remoting/client/jni/jni_display_handler.h
+++ b/remoting/client/jni/jni_display_handler.h
@@ -11,11 +11,11 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "remoting/client/jni/display_updater_factory.h"
+#include "remoting/protocol/cursor_shape_stub.h"
namespace remoting {
namespace protocol {
-class CursorShapeInfo;
class VideoRenderer;
} // namespace protocol
@@ -23,7 +23,8 @@ class ChromotingJniRuntime;
// Handles display operations. Must be called and deleted on the display thread
// unless otherwise noted.
-class JniDisplayHandler : public DisplayUpdaterFactory {
+class JniDisplayHandler : public DisplayUpdaterFactory,
+ public protocol::CursorShapeStub {
public:
explicit JniDisplayHandler(ChromotingJniRuntime* runtime);
@@ -34,7 +35,8 @@ class JniDisplayHandler : public DisplayUpdaterFactory {
void InitializeClient(
const base::android::JavaRef<jobject>& java_client);
- void UpdateCursorShape(const protocol::CursorShapeInfo& cursor_shape);
+ // CursorShapeStub override.
Sergey Ulanov 2016/07/27 20:38:01 nit: s/override/interface/
Sergey Ulanov 2016/07/27 20:38:01 nit: move this to private: section to make it clea
Yuwei 2016/07/27 21:01:36 Done.
Yuwei 2016/07/27 21:01:36 Done. That's interesting C++ logic... By overridi
+ void SetCursorShape(const protocol::CursorShapeInfo& cursor_shape) override;
// DisplayUpdaterFactory overrides (functions can be called on any thread).
std::unique_ptr<protocol::CursorShapeStub> CreateCursorShapeStub() override;

Powered by Google App Engine
This is Rietveld 408576698