Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2187713002: Only run recipe simulation tests if infra/ changes. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Only run recipe simulation tests if infra/ changes. This should lessen the need for mortals to have coverage.py, and saves 1.8s (of 3.6s) on my desktop for this non-infra change. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187713002 Committed: https://skia.googlesource.com/skia/+/3da80f5ecd98c9b3f46c23b85854b8f96025e565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein_C
4 years, 4 months ago (2016-07-26 22:41:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187713002/1
4 years, 4 months ago (2016-07-26 22:41:47 UTC) #6
borenet
LGTM
4 years, 4 months ago (2016-07-27 11:12:06 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 11:14:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3da80f5ecd98c9b3f46c23b85854b8f96025e565

Powered by Google App Engine
This is Rietveld 408576698