Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2941)

Unified Diff: ash/mus/accelerators/accelerator_controller_registrar.h

Issue 2187703003: Wires up registering accelerators from mash with the wm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/BUILD.gn ('k') | ash/mus/accelerators/accelerator_controller_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/accelerators/accelerator_controller_registrar.h
diff --git a/ash/mus/accelerators/accelerator_controller_registrar.h b/ash/mus/accelerators/accelerator_controller_registrar.h
new file mode 100644
index 0000000000000000000000000000000000000000..bb509bd878b2808c5ebf9d437867bde7de4c3c64
--- /dev/null
+++ b/ash/mus/accelerators/accelerator_controller_registrar.h
@@ -0,0 +1,98 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_
+#define ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_
+
+#include <stdint.h>
+
+#include <map>
+
+#include "ash/mus/accelerators/accelerator_handler.h"
+#include "base/macros.h"
+#include "ui/base/accelerators/accelerator.h"
+#include "ui/base/accelerators/accelerator_manager_delegate.h"
+#include "ui/events/mojo/event_constants.mojom.h"
+
+namespace ash {
+
+class AcceleratorRouter;
+
+namespace mus {
+
+class WindowManager;
+
+// Responsible for registering accelerators created by AcceleratorController
+// with the WindowManager, as well as routing handling of accelerators to
+// the right place.
+class AcceleratorControllerRegistrar : public AcceleratorHandler,
+ public ui::AcceleratorManagerDelegate {
+ public:
+ AcceleratorControllerRegistrar(WindowManager* window_manager,
+ uint16_t id_namespace);
+ ~AcceleratorControllerRegistrar() override;
+
+ // AcceleratorHandler:
+ ui::mojom::EventResult OnAccelerator(uint32_t id,
+ const ui::Event& event) override;
+
+ // ui::AcceleratorManagerDelegate:
+ void OnAcceleratorRegistered(const ui::Accelerator& accelerator) override;
+ void OnAcceleratorUnregistered(const ui::Accelerator& accelerator) override;
+
+ private:
+ // The flow of accelerators in ash is:
+ // . wm::AcceleratorFilter() sees events first as it's a pre-target handler.
+ // . AcceleratorFilter forwards to its delegate, which indirectly is
+ // implemented by AcceleratorRouter.
+ // . AcceleratorRouter may early out, if not it calls through to
+ // AcceleratorController. This stop may stop propagation entirely.
+ // . If focus is on a Widget, then NativeWidgetAura gets the key event, calls
+ // to Widget::OnKeyEvent(), which calls to FocusManager::OnKeyEvent(), which
+ // calls to AshFocusManagerFactory::Delegate::ProcessAccelerator() finally
+ // ending up in AcceleratorController::Process().
+ // . OTOH if focus is on a content, then
+ // RenderWidgetHostViewAura::OnKeyEvent() is called and may end up consuming
+ // the event.
+ //
+ // To get this behavior for mash we register accelerators for both pre and
+ // post. Pre gives the behavior of AcceleratorRouter and post that of
+ // AshFocusManagerFactory.
+ //
+ // These ids all use the namespace |id_namespace_|.
+ struct Ids {
+ uint16_t pre_id;
+ uint16_t post_id;
+ };
+
+ // Returns the next local id for an accelerator, or false if the max number of
+ // accelerators have been registered.
+ bool GenerateIds(Ids* ids);
+
+ // Used internally by GenerateIds(). Returns the next local id (as well as
+ // updating |ids_|). This *must* be called from GenerateIds().
+ uint16_t GetNextLocalAcceleratorId();
+
+ WindowManager* window_manager_;
+
+ const uint16_t id_namespace_;
+
+ // Id to use for the next accelerator.
+ uint16_t next_id_;
+
+ std::unique_ptr<AcceleratorRouter> router_;
+
+ // Set of registered local ids.
+ std::set<uint16_t> ids_;
+
+ // Maps from accelerator to the two ids registered for it.
+ std::map<ui::Accelerator, Ids> accelerator_to_ids_;
+
+ DISALLOW_COPY_AND_ASSIGN(AcceleratorControllerRegistrar);
+};
+
+} // namespace mus
+} // namespace ash
+
+#endif // ASH_MUS_ACCELERATORS_ACCELERATOR_CONTROLLER_REGISTRAR_H_
« no previous file with comments | « ash/mus/BUILD.gn ('k') | ash/mus/accelerators/accelerator_controller_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698