src/full-codegen/full-codegen.cc - Issue 2187693002: [Tracing] Embed V8 runtime call stats into tracing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2187693002: [Tracing] Embed V8 runtime call stats into tracing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index f53037235b94cbfeb7e49c43bd463aaf97c13f87..28dbcf1622ee9c6687215bfe18c1e556da6d337b 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -32,7 +32,8 @@ bool FullCodeGenerator::MakeCode(CompilationInfo* info) {

RuntimeCallTimerScope runtimeTimer(isolate,

&RuntimeCallStats::CompileFullCode);

TimerEventScope<TimerEventCompileFullCode> timer(info->isolate());

- TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.compile"), "V8.CompileFullCode");

+ TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_SCOPED(

+ isolate, &tracing::TraceEventStatsTable::CompileFullCode);

Handle<Script> script = info->script();

if (!script->IsUndefined(isolate) &&