Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2187643002: Ship canvas 2D imageSmoothingQuality (Closed)

Created:
4 years, 4 months ago by Justin Novosad
Modified:
4 years, 4 months ago
Reviewers:
xidachen, chrishtr
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, Justin Novosad, haraken, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship canvas 2D imageSmoothingQuality BUG=540761 Committed: https://crrev.com/f29da37fc8a3bafdfd1ba80b801cef4a2c265c83 Cr-Commit-Position: refs/heads/master@{#407925}

Patch Set 1 #

Patch Set 2 : fixed test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Justin Novosad
PTAL This is finally ready to ship. (Mipmaps fixed on ChromeOS). Got approval to ship ...
4 years, 4 months ago (2016-07-26 19:15:17 UTC) #4
xidachen
I think you will need an API owner to lgtm this. It is also likely ...
4 years, 4 months ago (2016-07-26 19:25:08 UTC) #5
Justin Novosad
+chrishtr for API owner approval
4 years, 4 months ago (2016-07-26 19:26:22 UTC) #7
chrishtr
lgtm
4 years, 4 months ago (2016-07-26 20:03:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187643002/20001
4 years, 4 months ago (2016-07-26 20:24:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 21:48:59 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 21:51:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f29da37fc8a3bafdfd1ba80b801cef4a2c265c83
Cr-Commit-Position: refs/heads/master@{#407925}

Powered by Google App Engine
This is Rietveld 408576698