Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2187633002: Revert of Add check for mismatching item and document sequence numbers. (Closed)

Created:
4 years, 4 months ago by nasko
Modified:
4 years, 4 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add check for mismatching item and document sequence numbers. (patchset #2 id:20001 of https://codereview.chromium.org/2172123004/ ) Reason for revert: Reverting this change as it has resulted in much higher number of reports than anticipated. We have enough data to investigate and can reland a modified version if needed. Original issue's description: > Add check for mismatching item and document sequence numbers. > > When a PageState update is received from the renderer process, it must > be for the current session history entry. This means that the sequence > numbers associated with the FrameNavigationEntry should match the ones > coming from the renderer process. > This CL is adding explicit check for this and a DumpWithoutCrashing to > help diagnose what cases can cause a mismatch. > > BUG=628677 > > Committed: https://crrev.com/e3e35c2d36325c10840b60d2a7cb2a7fe1c6cd14 > Cr-Commit-Position: refs/heads/master@{#407316} TBR=creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628677 Committed: https://crrev.com/10a855e46c9e920bcddd65b79f5047e35f1107ae Cr-Commit-Position: refs/heads/master@{#407893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nasko
Created Revert of Add check for mismatching item and document sequence numbers.
4 years, 4 months ago (2016-07-26 19:00:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187633002/1
4 years, 4 months ago (2016-07-26 19:01:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 20:07:04 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 20:10:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10a855e46c9e920bcddd65b79f5047e35f1107ae
Cr-Commit-Position: refs/heads/master@{#407893}

Powered by Google App Engine
This is Rietveld 408576698