Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: content/renderer/media/webrtc_local_audio_track.cc

Issue 218763007: Update MediaStreamTrack::Stop to latest draft. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments and added tests. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_local_audio_track.cc
diff --git a/content/renderer/media/webrtc_local_audio_track.cc b/content/renderer/media/webrtc_local_audio_track.cc
index d1b22234978b0da62a213448d0441989aede39a6..90c1ab6cdaeb688b08dee1b1868e4845a802c2fe 100644
--- a/content/renderer/media/webrtc_local_audio_track.cc
+++ b/content/renderer/media/webrtc_local_audio_track.cc
@@ -38,8 +38,8 @@ WebRtcLocalAudioTrack::WebRtcLocalAudioTrack(
WebRtcLocalAudioTrack::~WebRtcLocalAudioTrack() {
DCHECK(main_render_thread_checker_.CalledOnValidThread());
DVLOG(1) << "WebRtcLocalAudioTrack::~WebRtcLocalAudioTrack()";
- // Users might not call Stop() on the track.
- Stop();
+ // Users might not call StopTrack() on the track.
tommi (sloooow) - chröme 2014/04/03 08:53:16 is this something we should rather enforce than wo
perkj_chrome 2014/04/03 11:58:34 I would rather just remove the comment... StopTrac
+ StopTrack();
}
void WebRtcLocalAudioTrack::Capture(const int16* audio_data,
@@ -215,7 +215,7 @@ void WebRtcLocalAudioTrack::Start() {
}
}
-void WebRtcLocalAudioTrack::Stop() {
+void WebRtcLocalAudioTrack::StopTrack() {
DCHECK(main_render_thread_checker_.CalledOnValidThread());
DVLOG(1) << "WebRtcLocalAudioTrack::Stop()";
if (!capturer_.get() && !webaudio_source_.get())

Powered by Google App Engine
This is Rietveld 408576698