Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: content/renderer/media/media_stream_track.h

Issue 218763007: Update MediaStreamTrack::Stop to latest draft. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments and added tests. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_track.h
diff --git a/content/renderer/media/media_stream_track.h b/content/renderer/media/media_stream_track.h
index e1e2e4f5b61610c3d50fd541b983c00f6c3b32ff..30efc3ec1ffe86765ac552f4698293d81cf13e61 100644
--- a/content/renderer/media/media_stream_track.h
+++ b/content/renderer/media/media_stream_track.h
@@ -35,6 +35,10 @@ class CONTENT_EXPORT MediaStreamTrack
// If a subclass overrides this method it has to call the base class.
virtual void SetEnabled(bool enabled);
+ // TODO(xians): Make pure virtual when remote audio tracks has
tommi (sloooow) - chröme 2014/04/03 08:53:16 nit: s/has/have
perkj_chrome 2014/04/03 11:58:34 remote audio track has ...
tommi (sloooow) - chröme 2014/04/07 10:05:43 "tracks" is plural, so it should be "remote audio
perkj_chrome 2014/04/07 15:33:51 Done.
+ // implemented StopTrack.
+ virtual void StopTrack();
tommi (sloooow) - chröme 2014/04/03 08:53:16 Isn't it reduntant to have a MediaStreamTrack::Sto
perkj_chrome 2014/04/03 11:58:34 Done.
+
virtual webrtc::AudioTrackInterface* GetAudioAdapter();
virtual webrtc::VideoTrackInterface* GetVideoAdapter();

Powered by Google App Engine
This is Rietveld 408576698