Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2556)

Unified Diff: content/renderer/media/media_stream_video_source.cc

Issue 218763007: Update MediaStreamTrack::Stop to latest draft. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_video_source.cc
diff --git a/content/renderer/media/media_stream_video_source.cc b/content/renderer/media/media_stream_video_source.cc
index 31448b4e54db5ae92f530ea71cf6e25e679d167d..0acb355f4b1e00774c28da53b4a1ad4392b14858 100644
--- a/content/renderer/media/media_stream_video_source.cc
+++ b/content/renderer/media/media_stream_video_source.cc
@@ -27,14 +27,14 @@ const char MediaStreamVideoSource::kMaxFrameRate[] = "maxFrameRate";
const char MediaStreamVideoSource::kMinFrameRate[] = "minFrameRate";
const char* kSupportedConstraints[] = {
- MediaStreamVideoSource::kMaxAspectRatio,
- MediaStreamVideoSource::kMinAspectRatio,
- MediaStreamVideoSource::kMaxWidth,
- MediaStreamVideoSource::kMinWidth,
- MediaStreamVideoSource::kMaxHeight,
- MediaStreamVideoSource::kMinHeight,
- MediaStreamVideoSource::kMaxFrameRate,
- MediaStreamVideoSource::kMinFrameRate,
+ MediaStreamVideoSource::kMaxAspectRatio,
+ MediaStreamVideoSource::kMinAspectRatio,
+ MediaStreamVideoSource::kMaxWidth,
+ MediaStreamVideoSource::kMinWidth,
+ MediaStreamVideoSource::kMaxHeight,
+ MediaStreamVideoSource::kMinHeight,
+ MediaStreamVideoSource::kMaxFrameRate,
+ MediaStreamVideoSource::kMinFrameRate,
};
const int MediaStreamVideoSource::kDefaultWidth = 640;
@@ -353,10 +353,13 @@ void MediaStreamVideoSource::AddTrack(
}
void MediaStreamVideoSource::RemoveTrack(MediaStreamVideoTrack* video_track) {
+ DCHECK(CalledOnValidThread());
std::vector<MediaStreamVideoTrack*>::iterator it =
std::find(tracks_.begin(), tracks_.end(), video_track);
DCHECK(it != tracks_.end());
tracks_.erase(it);
+ if (tracks_.empty())
+ StopSource();
}
void MediaStreamVideoSource::InitAdapter() {
@@ -382,6 +385,7 @@ webrtc::VideoSourceInterface* MediaStreamVideoSource::GetAdapter() {
}
void MediaStreamVideoSource::DoStopSource() {
+ DCHECK(CalledOnValidThread());
DVLOG(3) << "DoStopSource()";
StopSourceImpl();
state_ = ENDED;

Powered by Google App Engine
This is Rietveld 408576698