content/renderer/media/webrtc/media_stream_remote_video_source.cc - Issue 218763007: Update MediaStreamTrack::Stop to latest draft.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/media_stream_remote_video_source.cc

Issue 218763007: Update MediaStreamTrack::Stop to latest draft. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed test WebRtcGetUserMediaBrowserTest.TwoGetUserMediaAndStop Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webrtc/media_stream_remote_video_source.cc

diff --git a/content/renderer/media/webrtc/media_stream_remote_video_source.cc b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

index 50468affe8ac06f9f615936d4d590cbf6316221f..9e63502697cec4ad6e4c93995548d1a136da94ea 100644

--- a/content/renderer/media/webrtc/media_stream_remote_video_source.cc

+++ b/content/renderer/media/webrtc/media_stream_remote_video_source.cc

@@ -47,8 +47,10 @@ void MediaStreamRemoteVideoSource::StartSourceImpl(

void MediaStreamRemoteVideoSource::StopSourceImpl() {

DCHECK(message_loop_proxy_->BelongsToCurrentThread());

- remote_track_->RemoveRenderer(this);

- remote_track_->UnregisterObserver(this);

+ if (state() != MediaStreamVideoSource::ENDED) {

+ remote_track_->RemoveRenderer(this);

+ remote_track_->UnregisterObserver(this);

+ }

}

webrtc::VideoSourceInterface* MediaStreamRemoteVideoSource::GetAdapter() {