Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2187613004: Try again to flip official win builders to GN. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try again to flip official win builders to GN. We believe we've fixed the remaining known issues w/ the upload/ signing scripts, so it's time to try again. This affects: - chromium.perf - Win Builder - official.desktop - win - win64 - official.desktop.continuous - win beta - win stable - win trunk - win64 trunk (Though the beta and stable builders aren't actually affected and won't be until they are on M54). TBR=sebmarchand@chromium.org, brettw@chromium.org, brucedawson@chromium.org BUG=623659 Committed: https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f Cr-Commit-Position: refs/heads/master@{#408318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M tools/mb/mb_config.pyl View 6 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187613004/1
4 years, 4 months ago (2016-07-28 00:43:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 02:41:39 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e28fd5d84cebeb446e2c35cf6b766e35aa56ec5f Cr-Commit-Position: refs/heads/master@{#408318}
4 years, 4 months ago (2016-07-28 02:44:27 UTC) #8
Sébastien Marchand
4 years, 4 months ago (2016-07-28 06:22:04 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698