infra/bots/recipe_modules/skia/resources/run_binary_size_analysis.py - Issue 2187603005: Fix Perf data upload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/skia/resources/run_binary_size_analysis.py

Issue 2187603005: Fix Perf data upload (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove uses of common.skia Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « infra/bots/recipe_modules/skia/resources/generate_and_upload_doxygen.py ('k') | infra/bots/recipe_modules/skia/resources/upload_bench_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/bots/recipe_modules/skia/resources/run_binary_size_analysis.py

diff --git a/infra/bots/recipe_modules/skia/resources/run_binary_size_analysis.py b/infra/bots/recipe_modules/skia/resources/run_binary_size_analysis.py

index f8c3c830ad7e42ede96647b38d6ff8567a47b9d1..5cb24d967a78ca6a1d73f712f90de3bc923a48af 100755

--- a/infra/bots/recipe_modules/skia/resources/run_binary_size_analysis.py

+++ b/infra/bots/recipe_modules/skia/resources/run_binary_size_analysis.py

@@ -95,9 +95,6 @@ import elf_symbolizer

from recipe_engine.types import freeze

-# Skia addition

-from common.skia import global_constants

# Node dictionary keys. These are output in json read by the webapp so

# keep them short to save file size.

# Note: If these change, the webapp must also change.

@@ -338,7 +335,7 @@ def DumpCompactTree(symbols, symbol_path_origin_dir, ha, ts, issue, gsutil):

# Use separators without whitespace to get a smaller file.

json.dump(json_data, out, separators=(',', ':'))

- GS_PREFIX = 'gs://' + global_constants.GS_GM_BUCKET + '/'

+ GS_PREFIX = 'gs://chromium-skia-gm/'

# Writes to Google Storage for visualization.

subprocess.check_call(GetGsCopyCommandList(

gsutil, tmpfile, GS_PREFIX + 'size/' + ha + '.json'))