Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: src/interpreter/interpreter.h

Issue 2187603004: [stubs] Using template magic to get the call interface descriptor type from callable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@code-factory-cleanup
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter.h
diff --git a/src/interpreter/interpreter.h b/src/interpreter/interpreter.h
index 48940d267fbf1b5f93ba232403728ee017b98ec8..8be1746100ab3d69c3964fa5e51db981a6655f0d 100644
--- a/src/interpreter/interpreter.h
+++ b/src/interpreter/interpreter.h
@@ -83,7 +83,7 @@ class Interpreter {
// Generates code to perform the unary operation via |callable| and stores
// the result to the accumulator.
- void DoUnaryOp(Callable callable, InterpreterAssembler* assembler);
+ void DoUnaryOp(const Callable& callable, InterpreterAssembler* assembler);
// Generates code to perform the unary operation via |Generator|.
template <class Generator>
@@ -94,12 +94,15 @@ class Interpreter {
void DoCompareOp(Token::Value compare_op, InterpreterAssembler* assembler);
// Generates code to perform a global store via |ic|.
+ template <typename Descriptor>
void DoStaGlobal(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a named property store via |ic|.
+ template <typename Descriptor>
void DoStoreIC(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a keyed property store via |ic|.
+ template <typename Descriptor>
void DoKeyedStoreIC(Callable ic, InterpreterAssembler* assembler);
// Generates code to perform a JS call that collects type feedback.
@@ -136,13 +139,16 @@ class Interpreter {
compiler::Node* BuildLoadContextSlot(InterpreterAssembler* assembler);
// Generates code to load a global.
+ template <typename Descriptor>
compiler::Node* BuildLoadGlobal(Callable ic, InterpreterAssembler* assembler);
// Generates code to load a named property.
+ template <typename Descriptor>
compiler::Node* BuildLoadNamedProperty(Callable ic,
InterpreterAssembler* assembler);
// Generates code to load a keyed property.
+ template <typename Descriptor>
compiler::Node* BuildLoadKeyedProperty(Callable ic,
InterpreterAssembler* assembler);
@@ -156,7 +162,7 @@ class Interpreter {
InterpreterAssembler* assembler);
// Generates code to perform the unary operation via |callable|.
- compiler::Node* BuildUnaryOp(Callable callable,
+ compiler::Node* BuildUnaryOp(const Callable& callable,
InterpreterAssembler* assembler);
uintptr_t GetDispatchCounter(Bytecode from, Bytecode to) const;
« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/interpreter/interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698