Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2187583002: Fix GrDrawContextPriv::stencilRect (Closed)

Created:
4 years, 4 months ago by csmartdalton
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix GrDrawContextPriv::stencilRect Updates stencilRect to call drawNonAAFilledRect instead of drawFilledRect. drawFilledRect can use coverage AA, which isn't appropriate for stencil draws. Also modifies drawNonAAFilledRect to take a "useHWAA" argument instead of trying to deduce whether it should be used. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187583002 Committed: https://skia.googlesource.com/skia/+/34ee0c950e1aa24818632084acdb382514f98c08

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix GrDrawContextPriv::stencilRect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M include/gpu/GrDrawContext.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 6 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
csmartdalton
4 years, 4 months ago (2016-07-26 18:01:03 UTC) #3
bsalomon
lgtm
4 years, 4 months ago (2016-07-27 17:38:00 UTC) #4
csmartdalton
4 years, 4 months ago (2016-07-27 17:48:20 UTC) #5
bsalomon
lbtm (looks better to me)
4 years, 4 months ago (2016-07-27 18:22:21 UTC) #6
csmartdalton
On 2016/07/27 18:22:21, bsalomon wrote: > lbtm (looks better to me) ha :)
4 years, 4 months ago (2016-07-27 19:28:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187583002/40001
4 years, 4 months ago (2016-07-27 19:28:12 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:22:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/34ee0c950e1aa24818632084acdb382514f98c08

Powered by Google App Engine
This is Rietveld 408576698