Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Issue 2187573002: Reduce usage of MakeRenderTargetDirect (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix "bug" #

Patch Set 3 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -74 lines) Patch
M include/core/SkSurface.h View 1 chunk +11 lines, -3 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 5 chunks +17 lines, -14 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M tests/DeviceTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +3 lines, -10 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 4 chunks +14 lines, -17 lines 0 comments Download
M tests/SurfaceTest.cpp View 4 chunks +6 lines, -7 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M tests/skbug5221.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
robertphillips
4 years, 4 months ago (2016-07-26 17:54:40 UTC) #10
bsalomon
lgtm
4 years, 4 months ago (2016-07-26 18:35:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187573002/40001
4 years, 4 months ago (2016-07-26 18:37:24 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 18:38:19 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7e922765545f42ce691e4f3d5fbbd4e44ba47ff1

Powered by Google App Engine
This is Rietveld 408576698