Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2187563004: gn: Switch off neon for V8 arm simulator builds (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Switch off neon for V8 arm simulator builds BUG=chromium:474921 Committed: https://crrev.com/329d9b8f8746f1748d73af35da33c05ce5b879be Cr-Commit-Position: refs/heads/master@{#408161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M build/config/arm.gni View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Michael Achenbach
PTAL As per discussion in https://codereview.chromium.org/2172193002/#msg9
4 years, 4 months ago (2016-07-27 08:16:03 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-27 08:17:43 UTC) #6
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-27 16:41:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187563004/1
4 years, 4 months ago (2016-07-27 17:08:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 17:12:30 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:14:23 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/329d9b8f8746f1748d73af35da33c05ce5b879be
Cr-Commit-Position: refs/heads/master@{#408161}

Powered by Google App Engine
This is Rietveld 408576698