Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2187543002: Reland of rename existing Blink try bots to include OS version. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
CC:
chromium-reviews, estaab, Michael Hablich, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of rename existing Blink try bots to include OS version. (patchset #1 id:1 of https://codereview.chromium.org/2185443003/ ) Reason for revert: Creating a reland CL. Master restart request: http://crbug.com/631512 Original issue's description: > Revert of Rename existing Blink try bots to include OS version. (patchset #2 id:20001 of https://codereview.chromium.org/2174553002/ ) > > Reason for revert: > This is breaking autorollers of v8 and skia. See http://crbug.com/631448 > > Original issue's description: > > Rename existing Blink try bots to include OS version. > > > > Purpose: To make builder names consistent, since builders > > for different versions of each OS are being added > > (http://crrev.com/2168483002), and those builder names > > include OS version. > > > > BUG=590036 > > > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/d8ce580ec8c7edd90c9d59a87898d77827237ea6 > > TBR=dpranke@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org,qyearsley@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=590036 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/1f8d0dbd778252296723f83f3f5d13637f499587 TBR=dpranke@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=590036 Committed: https://chromium.googlesource.com/chromium/tools/build/+/068af580da2693b5dca196885bb310b9800e344c

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -18243 lines) Patch
M masters/master.tryserver.blink/master.cfg View 1 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.blink/slaves.cfg View 1 3 chunks +12 lines, -12 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 1 2 chunks +26 lines, -26 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 1 9 chunks +19 lines, -30 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json View 9 chunks +12 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json View 11 chunks +16 lines, -16 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_compile_dbg.json View 1 chunk +0 lines, -411 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_compile_rel.json View 1 chunk +0 lines, -412 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg.json View 1 chunk +0 lines, -483 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg_fail.json View 1 chunk +0 lines, -727 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_dbg_pass.json View 1 chunk +0 lines, -483 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel.json View 1 chunk +0 lines, -484 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_fail.json View 1 chunk +0 lines, -729 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_blink_rel_pass.json View 1 chunk +0 lines, -484 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_compile_dbg.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_compile_rel.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_dbg.json View 1 7 chunks +10 lines, -10 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_precise_blink_rel.json View 1 7 chunks +10 lines, -10 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_rel_fail.json View 1 1 chunk +0 lines, -727 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_rel_pass.json View 1 1 chunk +0 lines, -483 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_10_blink_rel_fail.json View 1 1 chunk +0 lines, -770 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_10_blink_rel_pass.json View 1 1 chunk +0 lines, -504 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_11_blink_rel_fail.json View 1 1 chunk +0 lines, -770 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_11_blink_rel_pass.json View 1 1 chunk +0 lines, -504 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_9_blink_compile_dbg.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_9_blink_compile_rel.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_9_blink_dbg.json View 1 7 chunks +10 lines, -10 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac10_9_blink_rel.json View 1 7 chunks +10 lines, -10 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_compile_dbg.json View 1 chunk +0 lines, -433 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_compile_rel.json View 1 chunk +0 lines, -433 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg.json View 1 chunk +0 lines, -504 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_fail.json View 1 chunk +0 lines, -770 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_dbg_pass.json View 1 chunk +0 lines, -504 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel.json View 1 chunk +0 lines, -504 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_fail.json View 1 chunk +0 lines, -770 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_mac_blink_rel_pass.json View 1 chunk +0 lines, -504 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win10_blink_rel_fail.json View 1 1 chunk +0 lines, -749 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win10_blink_rel_pass.json View 1 1 chunk +0 lines, -503 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win7_blink_compile_dbg.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win7_blink_compile_rel.json View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win7_blink_dbg.json View 1 6 chunks +7 lines, -7 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win7_blink_rel.json View 1 6 chunks +7 lines, -7 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_compile_dbg.json View 1 chunk +0 lines, -427 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_compile_rel.json View 1 chunk +0 lines, -427 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg.json View 1 chunk +0 lines, -503 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_fail.json View 1 chunk +0 lines, -749 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_dbg_pass.json View 1 chunk +0 lines, -503 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel.json View 1 chunk +0 lines, -503 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_fail.json View 1 chunk +0 lines, -749 lines 0 comments Download
D scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_win_blink_rel_pass.json View 1 chunk +0 lines, -503 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/non_cq_blink_tryjob.json View 6 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json View 11 chunks +16 lines, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_skia_patch_on_blink_trybot.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/use_v8_patch_on_blink_trybot.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/webkit_tests_interrupted.json View 7 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/webkit_tests_unexpected_error.json View 7 chunks +10 lines, -10 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/webkit_tests_with_and_without_patch_fail.json View 1 11 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
qyearsley
Created Reland of name existing Blink try bots to include OS version.
4 years, 4 months ago (2016-07-26 16:08:13 UTC) #1
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-26 18:42:27 UTC) #3
Michael Achenbach
Tentative lg-tm if MB change lands first.
4 years, 4 months ago (2016-07-26 19:06:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187543002/1
4 years, 4 months ago (2016-07-27 16:11:41 UTC) #11
commit-bot: I haz the power
Failed to apply patch for scripts/slave/recipe_modules/chromium_tests/trybots.py: While running git apply --index -3 -p1; error: patch ...
4 years, 4 months ago (2016-07-27 16:11:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187543002/300001
4 years, 4 months ago (2016-07-27 16:29:31 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 16:30:02 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:300001) as
https://chromium.googlesource.com/chromium/tools/build/+/068af580da2693b5dca1...

Powered by Google App Engine
This is Rietveld 408576698